From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77D3A227EA3 for ; Thu, 13 Feb 2025 13:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739453762; cv=none; b=Uqq1bUwGn128nDzthKWC8saBA9rXvAwG1v7pUlrS3WtPJRxfM60gwxs8vlMnp5EKGaAcAvroLTbLiV1zkNseQFVUm9sG8go9g0GdTFmjV+bE/ZoPLf8/xkqRNUubjLXRN0KaMlJOEn2DhKTmwebu+pxQtYGCRFEnwKL8R6DFMYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739453762; c=relaxed/simple; bh=yVvqosbfBaZN59lYnyfV7wTLt5V4gEraGzYMEdvy9dQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZuWkd3NciHORxjbvyJ3Fq8QseBfv3e+h2s+JpQVSTDrw/46DyH38xqB0of+6ABswVfpKbFnF2m/cJCfhZzPLorEB4mUuiKJYWzqsBv8JLJXgQkvuXkps8rBIe0NhnY1bEUC9h8TuZABUZ+oedbrn1p/KPXo+YgiVzKbFjKBkIto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Kwt7lkya; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Kwt7lkya" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4395f81db4dso5337145e9.1 for ; Thu, 13 Feb 2025 05:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739453759; x=1740058559; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4lyrHtSipeKghn9xCx+8COWh0BWty29N6DnBPAUwOek=; b=Kwt7lkyaR7i6RrsjyNhunBJrvwQ8PXiwnQrRIwvma4UE9b7JHJrXhnWmKdcHFUd412 vgm9xVjTo4qjZ/7U96UoghzM4axpKsuVKDaGOsPAg1CAU5hd6tl8gh4QSYcueulLlTHu FOFu3Md9p8T/s9a0/YQyUG/UOD3FVUaXvm8N22vT6JNGk/nWq/9a0J/HyI9gZBY9p7ZQ 82VSje2duFX2/HKYxhCsKl0XibsWajIn52wj4a+mulVCLFUTii/5xS/04GoYzQkwpuIr 4K0edys8eZrTSRk52uIyTxC96ieJjwefLQETEldsFGRnnjeL71qnfYv+L1h529jznoOG 8kZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739453759; x=1740058559; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4lyrHtSipeKghn9xCx+8COWh0BWty29N6DnBPAUwOek=; b=QofdEfdklwWVHKVkzxdS6GOzvo3BXGa04ErgSM84JA2vauWKIFQG3Gld0v3ZTXvk2U qaLu7N8+fz/WXCfZxxCfInFjrxP7yFZuUpOvPbHvsifEE+QoR7ycKrXhm2YArvez0u/E h2Edn/kF+OlQeA0IDnbZjryX8MC27UqdZU0FtzJYOiqgqI2LKJIOUBOjHYg3/rzKGilv 30JmODfhFd2YeuZlknv6tNlBoAoRAo+UNZaeYed1wgwinYE3G86MJuoqIl2djRk7V9ks 6i5mt0EjHsaebnHi1rkbEJbbadUBmtuYtTtoxcF1k4S7BcTedllz/8GWQ37nGSDHbiQP eQFQ== X-Forwarded-Encrypted: i=1; AJvYcCU8tDn8n20ngV2umpfcWeLv1Q2RjA/DrRhmSr6CJPySkb7T64vgfEbulWex4ijk8GdXOjCDgFfq9GNeXdA=@vger.kernel.org X-Gm-Message-State: AOJu0YywWtH/LqylaKnCPdpKfJxl/N39ULKBwXkydZvIKAafYLlTwqOa PU+pKMpCEqvMW9IvsRrLBH8NVGKuynnFMnLtikBhx0TDyXOxw4oZ87aRZWiCk4g= X-Gm-Gg: ASbGncsNO+/zcT8EtYThhEvXs9cXZqNZAkH88t8D6DOeeAsP6BeBjw/uP+VYlMCwQ32 s5EZOf9nz/0aXXm91N+8F5EsKJ9XsOW+hw4TLSliYgxNsRjWeRGmegWElSW+jvV8ozribB/gnPE CtBtG89hFo2sXi38VD/ghyo2WCdqaGyN2cxw3UQGY9doPU+vcB2V8ndD1QQkwQ16H8yI3YpXlII I3leeEZ+m9JSG+CS8FyYjdHulN4aDHESEa7rK5YuBiZH09D+9Y4sJli6UJCJqaIJw7FdC0h+IFi biy+hTaDfGqm9w== X-Google-Smtp-Source: AGHT+IFlyyROQN/jp5N25OPHAwGGncnJ/FLwqH6qkR/P/8dmal2Zk5G/l0wZieziiMnBJNT5H1Y22g== X-Received: by 2002:a05:600c:a0c:b0:434:f1bd:1e40 with SMTP id 5b1f17b1804b1-43960e81b92mr29235125e9.6.1739453758160; Thu, 13 Feb 2025 05:35:58 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:b617:2c1:fc8c:2705]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4395a056151sm49618825e9.16.2025.02.13.05.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 05:35:57 -0800 (PST) From: Jerome Brunet To: "Arnd Bergmann" Cc: "Greg Kroah-Hartman" , "Dave Ertman" , "Ira Weiny" , "Rafael J . Wysocki" , "Stephen Boyd" , "Danilo Krummrich" , "Conor.Dooley" , "Daire McNamara" , "Philipp Zabel" , "Doug Anderson" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "laurent.pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Dave Airlie" , "Simona Vetter" , "Hans de Goede" , Ilpo =?utf-8?Q?J=C3=A4rvinen?= , "Bryan O'Donoghue" , "Vladimir Kondratiev" , "Gregory Clement" , =?utf-8?Q?Th=C3=A9o?= Lebrun , "Michael Turquette" , "Abel Vesa" , "Peng Fan" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Kevin Hilman" , "Martin Blumenstingl" , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH v3 7/7] clk: amlogic: axg-audio: use the auxiliary reset driver - take 2 In-Reply-To: <73c1ab6b-fd5e-47e3-8815-8f74758535f1@app.fastmail.com> (Arnd Bergmann's message of "Thu, 13 Feb 2025 13:26:12 +0100") References: <20250211-aux-device-create-helper-v3-0-7edb50524909@baylibre.com> <20250211-aux-device-create-helper-v3-7-7edb50524909@baylibre.com> <73c1ab6b-fd5e-47e3-8815-8f74758535f1@app.fastmail.com> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Thu, 13 Feb 2025 14:35:56 +0100 Message-ID: <1j1pw20xxf.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu 13 Feb 2025 at 13:26, "Arnd Bergmann" wrote: > On Tue, Feb 11, 2025, at 18:28, Jerome Brunet wrote: >> >> I also think this is more readeable and maintainable than a bunch of >> 'default CONFIG_FOO if CONFIG_FOO' for CONFIG_RESET_MESON_AUX. This approach >> also would have several pitfall, such as picking the value of the first config >> set or the config of RESET_MESON_AUX staying to 'n' if CONFIG_FOO is turned on >> with menuconfig. > > I still think you should just drop the 'imply' line, all it does it > force reviewers to double-check that you didn't make a mistake > here, so it's a waste of time. Arnd, you've made you preference clear and this note has been added specifically for this reason, and transparency. I've exposed a technical reason for my choice. Going with the 'default' approach makes things more difficult in the long run for those maintaining this platform, me included. The trouble of having to coordinate changes in 2 different subsystems to have an appropriate configuration and the pitfalls of using 'default' outweigh the extra review trouble of using 'imply' ... especially when the pitfall mentioned in documentation is explicitly addressed in the description. If there something wrong with 'imply' existing and being used, maybe the Documentation should be updated to reflect this, or the support be removed entirely. ATM, it exists and it makes things a lot easier for me to support and maintain this device. This all started with a maintainer request to move some resets away from clock. More requests have been added along the way, making things more generic. I'm more than happy to have contributed my effort and time on this and I don't think anybody's time has been wasted so far. > > Arnd -- Jerome