From: Jerome Brunet <jbrunet@baylibre.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Da Xue <da@libre.computer>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: add device for Genesys Logic hub gl3510
Date: Mon, 11 Sep 2023 18:46:24 +0200 [thread overview]
Message-ID: <1ja5ts4pyi.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20230810231748.GA1543958-robh@kernel.org>
On Thu 10 Aug 2023 at 17:17, Rob Herring <robh@kernel.org> wrote:
> On Tue, Aug 08, 2023 at 12:07:45PM +0200, Jerome Brunet wrote:
>> Add gl3510 USB 3 root hub device id
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> ---
>> Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> index cc4cf92b70d1..a7e7142651f8 100644
>> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> @@ -4,7 +4,7 @@
>> $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
>> $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> -title: Genesys Logic GL850G USB 2.0 hub controller
>> +title: Genesys Logic USB hub controller
>>
>> maintainers:
>> - Icenowy Zheng <uwu@icenowy.me>
>> @@ -17,6 +17,7 @@ properties:
>> enum:
>> - usb5e3,608
>> - usb5e3,610
>> + - usb5e3.626
>
> Should be a comma, not a period.
>
Good catch, thanks a lot
>>
>> reg: true
>>
>> --
>> 2.40.1
>>
next prev parent reply other threads:[~2023-09-11 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 10:07 [PATCH 0/2] usb: misc: onboard_usb_hub: add gl3510 support Jerome Brunet
2023-08-08 10:07 ` [PATCH 1/2] dt-bindings: usb: add device for Genesys Logic hub gl3510 Jerome Brunet
2023-08-08 10:17 ` Krzysztof Kozlowski
2023-08-10 23:17 ` Rob Herring
2023-09-11 16:46 ` Jerome Brunet [this message]
2023-08-08 10:07 ` [PATCH 2/2] usb: misc: onboard_usb_hub: add Genesys Logic gl3510 hub support Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ja5ts4pyi.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=da@libre.computer \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox