From: Jerome Brunet <jbrunet@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH] clk: Don't cache errors from clk_ops::get_phase()
Date: Tue, 07 Jan 2020 10:44:32 +0100 [thread overview]
Message-ID: <1jblrfsirj.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20200105075556.60E1A20848@mail.kernel.org>
On Sun 05 Jan 2020 at 08:55, Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Stephen Boyd (2020-01-04 23:50:49)
>>
>> Quoting Jerome Brunet (2019-10-02 01:31:46)
>> > >
>> > > + clk_core_get_phase(core);
>> >
>> > Should the error be checked here as well ?
>>
>> What error?
>>
>
> Ah the error when clk_ops::get_phase() returns an error? I guess we
> should just silently ignore it to maintain the previous behavior?
Indeed, that's the previous behavior so we can keep it.
I'm just not a fan of silently ignoring errors. These choices tend to
come back to haunt us ...
> Or we
> can bail out of clk registration. Seems low risk to do that in another
> patch.
Why not, or at least a warning so we get a hint that something is wrong.
prev parent reply other threads:[~2020-01-07 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 17:44 [PATCH] clk: Don't cache errors from clk_ops::get_phase() Stephen Boyd
2019-10-01 21:20 ` Doug Anderson
2020-01-05 7:53 ` Stephen Boyd
2019-10-02 8:31 ` Jerome Brunet
2020-01-05 7:50 ` Stephen Boyd
2020-01-05 7:55 ` Stephen Boyd
2020-01-07 9:44 ` Jerome Brunet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jblrfsirj.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox