From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E872F376465 for ; Thu, 11 Jun 2026 08:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781166540; cv=none; b=ijM8rnVMLhKaxzYor3t2a/NnFvYRBf5eLXPdiuSWiT68G/RLMGCSnmFHIhQVNo9v3Pzm4Hq6+7P0IKlTPp/oWZWBnseeK00jqrXJTeySjW3fkkf/dR0aculf1Dpy4NotW0FtDsYEioJgibf4fiYJgQlGU0nmLHESR1JamfdwyaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781166540; c=relaxed/simple; bh=BKPbMz4ymqlyl4qu11XKJ0++jaotO1IK3S+yeAc9SEc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=r0PE587RyaCux6Ok3ZQCfcXSEguwq0LWJRhN8OUHm4KT5uO1TRTdW/VQj499KAlhXhiugBVfLXJx5m0fI0QrHNOF2ef9Pryk2khlkcqf2DQ5NWVJFIGqshVQ3ajGNYX0V5NXQunTAsNf1QXlIUdoMfkkgqDEcKPn2Nlm0CActFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=U5/Y+yLL; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="U5/Y+yLL" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-490b9318997so56321675e9.2 for ; Thu, 11 Jun 2026 01:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781166535; x=1781771335; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=q+GZxQR0zVGYyc7t6dGL8c2RABIohdt9U+GPG+DCKw4=; b=U5/Y+yLL21yPCpPx1cR/Qdw1LhmWCEoAMHqHuo1i4vqMOqPUg8q1YDn0+nnwlQRluH EElnGP4vdh6sPk9JrWakAzbos3MllJsNpNRy7mQcwKY4tNGYcTTc6A8rRiBenHrH7YIu hNb0LUAiW0TzguVcEh3ZVnM6uuv3C5mYRdRstMUKIePJYF7GPb2pFceFO11nX24p585y tALoRdGGGj6/PP4dRSnuSxpsnJ8W0dPXK+Bga+JJaiY93xyFNcSJHaqQTnm++AmCCaUU 4uABUogWlcNJ//TGg++FLCrmliqIxceoxs1ouToEYzo8XXDpU/w2Erc8q4MbZxnQBfqr u2Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781166535; x=1781771335; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=q+GZxQR0zVGYyc7t6dGL8c2RABIohdt9U+GPG+DCKw4=; b=dTnFtu/XOJC20hmTS9nLDbYqYa3abAQ7ldh1yTU/ZrHVYSGGINeegB8OB0conwDDez ejFjt+qizKpjdMwRwQZyaneIFh4WUVkpEZU2g1OXAr/rKcEFiDcNfsXjLCeb72L2udJr s4xuG9szIwY2Qw7C6BfRjanUnNR/ow77lg4E0KIPgP6IOOB1ANV2ALI54nTWezZ1x/LX nWOHWLrsgrerOtbupvK3lKNqoXnovXRXlH97DjGh1YuHTDeUkJkjTlXapPJfinuzsMpo i7uEAwgm4DixkBdelj7CTXoP9iImZTJx6TAzM2/OzJY1z25b897UYVSHdgMpqaj3ngaD CkfA== X-Forwarded-Encrypted: i=1; AFNElJ+zBZDF9WbkhIHHhlJ4wLcZ2RxgAwBsqIzwgnm4OjsaFWlgKDinZlqciapWtEP0luwYrD9KZ3kJet8Xgxo=@vger.kernel.org X-Gm-Message-State: AOJu0YxRbKb7XsKFWcR1rfe8WdtW9n3nuxEF1VdpU2dEIeLjDnNUQH28 RTSVLVNjdfZzJLRX6tQa9Gm4KtlUlCO+hxazvXLZ9UcmipTuVpMETC0M2YgbJGS767g= X-Gm-Gg: Acq92OFh9kciPtir1kHBf/H8CKTPKpWgFYof1So8LZAxw4sdyc7L0oHhnAZEm7pmC12 VOJXl+d0TbXz+oMTXK5y/cSewXXeRUpS8EskRwu1JD3vKOefw/JDKvWLWljQkUTHV4GtLYSg/Bx /Zq8siKZcj4Hy/tvCSt9CPLSJIIck9OUbZdkp22BI64/7U2ZmHAxq5h+9mJ/zgZPJZrhclR03ib ye+9x8rVul8RD5uJY2MXIleHOVkG1olo7xLcs5OBiQ7OPcEZq6nczuczp1kA+bE9hpZsBPfTiMp 1YO5ZCX1vMHBaQ1M/QdWginVY6+K+JoGu2J+K0t88DVYhpjhQCJwrBtG7r1OFrFJmP3PwG60ofs cH2CN7fI3MstZShs89ttE79iddM2lC35zHQ5AX5vqD8cmsLoxrdi+DBZxhTQUBeQN9m52Ky1BSL L5VRvE597eAhpT8QvIxyn8coPT6knZa2dS X-Received: by 2002:a05:600d:8450:10b0:48e:6db3:ff2e with SMTP id 5b1f17b1804b1-490e55dd891mr14395135e9.15.1781166535248; Thu, 11 Jun 2026 01:28:55 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:1d1b:88ba:5161:3581]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4601f35133csm75931032f8f.25.2026.06.11.01.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 01:28:54 -0700 (PDT) From: Jerome Brunet To: Valerio Setti Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH v2 0/4] ASoC: meson: aiu: align I2S design to the AXG one In-Reply-To: <20260610-reshape-aiu-as-axg-v2-0-cac3663a8b51@baylibre.com> (Valerio Setti's message of "Wed, 10 Jun 2026 23:29:24 +0200") References: <20260610-reshape-aiu-as-axg-v2-0-cac3663a8b51@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 11 Jun 2026 10:28:53 +0200 Message-ID: <1jcxxxeb0a.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On mer. 10 juin 2026 at 23:29, Valerio Setti wrote: > The goal of this series is to reshape Amlogic GX's AIU implementation for > I2S to let it follow the same design as in AXG's TDM. Keeping the same > design allows for unifying the two platform implementations in the future > and it also allows for an easy addition of I2S input. > > The first commit introduces gx-formatter as the basic block which takes > care of properly formatting audio data. Formatters are DAPM widgets > (c.f. axg-tdm-formatter in AXG) which are dynamically attached/detached > to the streams when the latters starts/stop, respectively. > aiu-formatter-i2s is introduced as formatter implementation for the i2s > output. > > By the end aiu-encoder-i2s will only need to handle interface clocks and > enforce interface wide rate symmetry (c.f axg-tdm-interface on the AXG > platform). Right now rate symmetry is not relevant because only i2s output > is supported, but it will become useful when following patch series will > introduce the i2s input part. > > This series was tested on an OdroidC2 board (Amlogic S905 SOC) both with > HDMI output and with NXP SGTL5000 codec connected to the I2S pins. > This series was also verified using "pcm-test" test tool and all tests > are passing. > > Changes in v2: > - Fixed most of the weaknesses found by Sashiko review tool [1]. > - Resolved testing failures with "pcm-test" as reported by Mark Brown > (thanks for the heads up!). I left a comment in > "aiu_encoder_i2s_startup" to explain the fix. > > Link to v1: https://lore.kernel.org/r/20260515-reshape-aiu-as-axg-v1-0-53b457784ff3@baylibre.com > > [1]: https://sashiko.dev/#/patchset/20260515-reshape-aiu-as-axg-v1-0-53b457784ff3%40baylibre.com > > Signed-off-by: Valerio Setti Nice work. Thanks for taking the time to understand the existing drivers and build upon them ! Reviewed-by: Jerome Brunet Feel free to add yourself as maintainer of the Amlogic audio drivers, if you fancy doing so ;) > --- > Valerio Setti (4): > ASoC: meson: gx: add gx-formatter and gx-interface > ASoC: meson: aiu-encoder-i2s: prepare for multiple streams > ASoC: meson: aiu: introduce I2S output formatter > ASoC: meson: aiu: use aiu-formatter-i2s to format I2S output data > > sound/soc/meson/Makefile | 2 + > sound/soc/meson/aiu-encoder-i2s.c | 281 +++++++++++++++++++++++++---------- > sound/soc/meson/aiu-formatter-i2s.c | 104 +++++++++++++ > sound/soc/meson/aiu.c | 32 +++- > sound/soc/meson/aiu.h | 4 + > sound/soc/meson/gx-formatter.c | 282 ++++++++++++++++++++++++++++++++++++ > sound/soc/meson/gx-formatter.h | 56 +++++++ > sound/soc/meson/gx-interface.h | 48 ++++++ > 8 files changed, 731 insertions(+), 78 deletions(-) > --- > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > change-id: 20260515-reshape-aiu-as-axg-1dac9037cad3 > > Best regards, -- Jerome