From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DACAC37B00C for ; Sat, 11 Jul 2026 12:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783773439; cv=none; b=shdLpcUy8RgaGgmksvLzcVE/FxxM1BA1iNgBkZpXN4RunEeT8vhBsJxRXS3EedL0qOWvH0HoSTtQYHvAnmAPH6M0wgpnvkLo9nxpk1CIYS0nGwbNRLqQuRZEM7yKbDRxAp2E1fci3yDyKr+yyeT9ikljS/VdPHSHMNsISdZfa04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783773439; c=relaxed/simple; bh=ler0GzfWUTyNFlLtbWwwKBYDR6wTO+FQxowU5or1aQw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=tOqsG8SyvdERQhi3eKVMeGSoGlpDZBSn/+yw/gX1+V4hajsjqi6YlyGxi6mg4V1v78gHvCSEz4AJfjTVych+k/Ywyn5k15+z/o221QaYZYvXNxE9PaXwKXHD5zq5R/bpQJGjqEbR+5chl+aFCyUv834eSGOyfGMBT+sVej02G1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=fxdcpi4i; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="fxdcpi4i" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-493ece78b0cso13029355e9.0 for ; Sat, 11 Jul 2026 05:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783773434; x=1784378234; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=657uWlKxYcjOrN1ZXHDJlUFUQIWJmQtJufOMVNxlA+g=; b=fxdcpi4i7FjwCmco+jnDh8SipaouenBpGGu0QHIlwVUxNpD3S/RzqwR5LW/CThwqf1 NQutWwt2M+X0Q/TaYpfr2QvRbnLHO43AedkRk5awaOR5R1CwxjY5+Ivp26hWXRv+11BP LTuLXNoUUtqRHmx1pIujx6uTbiGxNlsnSwcx7wuNhvooFKbLnb/LfQf5Dnm0AqdGlIGG uhDGyeoxV4CKdXFiVLEV9Cbbq5hSBhzsTp8kRPzlDNb4qNHmGENiQ789/aN9xJiGJnZi /n0ZXvw3aEgYbAHsS8pK7d/iZ7gj0/fAx27okS94bxFknCY272R6aZPZGU6ijSlyR29t QcOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783773434; x=1784378234; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=657uWlKxYcjOrN1ZXHDJlUFUQIWJmQtJufOMVNxlA+g=; b=Ibqtb2qnQQT1OECf4VNvc88EsHrqAnLKgOvQ3YRR8c31F2yjWfPjwqWrHKB36CPYYL JqvRTH0hmEvtfcUdfTZJi3Y8KKYSwFbo1q7w/4e9C4XTqdEgAT5nyQRUX4heAv7gSPNA iPbQdv3AcpHPnLEVSNAb3lxCy5Z0eLMA56xW2iq6OdM8RX/bzFpFwXtIZVoSkkuYgYy4 cmguEJTNGl1/gBHnb8QjwIplA5t6xvcwMtNthcuGcig0V2dC0UEc8zg+5vfPVs62Gip3 rT/OBeKnzcj/okQDdJeDELA/gqyxLxzeEkDZX56mTQ++TpeYbFLd/MpFj/Jo4YeC3gBt +WOg== X-Forwarded-Encrypted: i=1; AHgh+RpXc6TMn9Mb0H9g10Fzg7aKhJXTIow0Y62ohpR6vuaiVS+g1aoeOlGwAYaApTHo/6jiysFjMxd7nTJ3iRo=@vger.kernel.org X-Gm-Message-State: AOJu0YwDVj8ceSHOUycT7k6o0hLL4H58uvERknMJT75xhCSF5ihp5/sv 9Zm7gjmAohL1MROHxwSLaPsFa+ovOvs54zvbIi51uKt4DccsJuSPhfTqqk7LtHvelnartqo8Bkj dWMC3 X-Gm-Gg: AfdE7cmd3qGRum1GhUNM+ldVJnyFrtJV91Yrf8Css1PBRWftW64tEARmHn+3WdpmYSx yUTIEQMK39aKj1ZCh51BgHkmyTqdC0r9QF6Vcfs+OBstH5zsHhG2ahjUkkNzmaBIy4q9kFpsoMk 24x09e8wihLNJVBa8sdq2uVMBL1TNqDYsR7tUIPtH3twbKJ4lcY7o3y0AGcJ4NZU42EYY+vlxog Fx+axproGpudLqWLxECG1lItBZqYoGdX8Qu2Re/VNWDEyuOBMvYsguHqTsAtetIy8JWiX9a/oe4 i3l1rxtrKtSt/Rih5LAiMiiBpIsv+o8LsqqFkWhZJV132VAj2DVZIwwCAFHKxm2vwjpD84XuSzV drGWzGS37pgv/HhumGI2M7UsgdlBCwsX7tT00Pr5klrp2+gV85/3EC5AvCZsiD8MpR0AxlLWWef 2quGU5ZJUqecw= X-Received: by 2002:a05:600c:a31c:b0:493:fd5b:2d5c with SMTP id 5b1f17b1804b1-493fd5b3043mr44175e9.22.1783773434236; Sat, 11 Jul 2026 05:37:14 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:36f6:4178:92a5:91bf]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-493f2dad65fsm87890305e9.1.2026.07.11.05.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 05:37:13 -0700 (PDT) From: Jerome Brunet To: Mark Brown Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Przywara Subject: Re: [PATCH v2 3/3] regulator: axp20x: add support for the AXP318W In-Reply-To: (Mark Brown's message of "Fri, 10 Jul 2026 18:00:24 +0100") References: <20260710-axp318-regulator-v2-0-ee5f1c56b49f@baylibre.com> <20260710-axp318-regulator-v2-3-ee5f1c56b49f@baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Sat, 11 Jul 2026 14:37:11 +0200 Message-ID: <1jmrvxg0so.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On ven. 10 juil. 2026 at 18:00, Mark Brown wrote: > On Fri, Jul 10, 2026 at 06:19:27PM +0200, Jerome Brunet wrote: > >> +#define AXP_DESC_RANGES_DELAY_OPS(_family, _id, _match, _supply, _ranges, \ >> + _n_voltages, _vreg, _vmask, _ereg, _emask, \ >> + _ramp_delay, _ops) \ >> [_family##_##_id] = { \ >> .name = (_match), \ >> .supply_name = (_supply), \ >> @@ -436,10 +481,23 @@ >> .enable_mask = (_emask), \ >> .linear_ranges = (_ranges), \ >> .n_linear_ranges = ARRAY_SIZE(_ranges), \ >> - .ramp_delay = (_ramp_delay), \ >> + .ramp_delay = (_ramp_delay), \ >> .ops = &axp20x_ops_range, \ > > This macro takes but ignores an ops parameter. Indeed, completely messed up as noted in reply to the cover letter. Sorry about that. Tested something, sent something else (and other mistakes ...) -- Jerome