From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7709A371893 for ; Thu, 11 Jun 2026 08:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781165441; cv=none; b=UzfjVltvbqCwdQxO/hcM0jOxO0POVDAcds6ahwHPli+YWINim6vWoSz0HKvvokCn2FYhDDR60vwnpIO8GkK/bwvV+dGS02FVoG13nbd9rseHoAbOX69ry7DWg52e7LWErkcyWFDvt12dHFAnrSpMsGkN2q6eAzLZrtzwYsmnGD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781165441; c=relaxed/simple; bh=WDdNQ3xUq1znEbfuhWk0wt6rDGXzaK70N8vgyWplY6Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=tWcEQotxWQJNRpbhcGgbQAcCwZTEOgcJeZbmkt4ifYbXla2c7Hc4UB98NbF41oZ+r1+Blo8Cz922etT0Wuj/66ATqIxeDLZ+Q5MVzb46MPtoyvQdeKqKjlFt+vNTiyfpkJXgZUEKodoWz4mmK09AuU7wgRupWHrTqYdkD1yRE5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=BjZwzkyf; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="BjZwzkyf" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-45ef616daf6so7153985f8f.3 for ; Thu, 11 Jun 2026 01:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781165438; x=1781770238; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=i8WaiBhZCg2JUQSyC77l4KARDvtWcKvB5SXOsU+dVgU=; b=BjZwzkyfb1yzuy9dY3rYYtBA2TjdzK4mBBp+RRhh9RfpbT/DToHP55yP9HJfPliZ2J gPHAnMCLmeKI1txluN9UsZ2hxGrpmUJe2M6lXCwq0emcqku3U/zmdNX+db1seDM/fF5F qGRyNtdeP3Oi+CpNhGcxIjQhVV6yS/MJ8DNfAdkxVltDg9fSrF/xWAPvRAfenymZQtbJ Fej4tdos/ZGkrtwZOwejMIKoojKWIVYs+P16MJRM+y9H0wiLcuGBv7G5wVBCAApYqIk5 thZs03K9m93bI9moQPFcjcmRp8UK7l2wy/sM/itEh2bcG8ZwIN0i1GDwECLXTFmAvIiP 2z/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781165438; x=1781770238; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=i8WaiBhZCg2JUQSyC77l4KARDvtWcKvB5SXOsU+dVgU=; b=tI8T1HAQzyb2GkGoKUHF1FRY9/Q9Z4RYZZjwn1q0PxpCe2MYgER4bxuBJsZohdp6EX GhiLqwugHGhHt9sH+Y/YqZmU0tBHuGDo+sFZcIjvd4ZmStkJOFwG9RSSUJqinT53Ttcd Qw2rVY70NRRJI9F5gb63d+d1db06n/CGeoycKkk3H2q8PlrerMqwxbrmkzVUH4g4K2VY QvVCxxD6vlItpXW0Wi7lec2eXAgGdoLtToTpseyTKUN/KKk/A0jDR6mfxTAaS1O0XWjx MtQWu1pNudgvgWvLmVASAdn9eZATqWNx4FvRfE0J9K8690pMfIbeiZkK/Ep6SGq+BbTK HaGg== X-Forwarded-Encrypted: i=1; AFNElJ+aTGY+bbI3zD1545baRjRr1PRgoyf6qkmgd9SP8u8/yY2LZal1GBuTgGb5NPlfA/DkJrCznvb/N6tzIzU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLpSN1Ko8aJSx49t8ielDTmHP3OOfTKFWeQeoAMjudRwdqwm2l uNeKSVTkY33+Yhd3TQjEtyKBAajzAxR4Bi1/Y1/zgmzPMDUxanPSVeAF23L7VOqgr0Q= X-Gm-Gg: Acq92OFlxTsxiZVYt1ZWCen9L4Nx/PaseIdlsliQ3lnrOM5ojEuqosP7FZ9qv5+sYyV BJ/KEeYwHuibB6b+/XnaJaah9mk8Adbj9sotdXCAB8uDl+bxy18nmofXZGRSHZLqdMAzOS2L83l bfs/opxHDIhByTdXSHb7KBgfz22YXYSYLlFnWNJThwQjv4DMKRgaMoKZ93tXol1MByGAGyf7HE3 HeQJSd9L+JWH5h9Aed6fzoTwiFmcHj8L4zyQiFcs5gmFqMwSBL2jmGyU3LI7Mz/+94mZEl17fRG yyXqXiz/QldyOpTe813frQX1ExxStHuTgpP7GrfKkYcdvKhc+V10YHP6wIjCDushrd2q5d9Fwdt Z3RhA4q5qdUDBBdQ946OyyDd7UPMWLpVvIvcdJRPAjAojA8VfpVwNP3cRyNbDefEJuXulP1smKx chLrr18/8mJmycL0a1xtRBhCwy0ejO2TEjW8T+WWWjaNY= X-Received: by 2002:a05:6000:46dc:b0:45e:ea65:d329 with SMTP id ffacd0b85a97d-4606758d002mr1861604f8f.7.1781165437896; Thu, 11 Jun 2026 01:10:37 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:1d1b:88ba:5161:3581]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4601f2e4004sm78864656f8f.9.2026.06.11.01.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 01:10:37 -0700 (PDT) From: Jerome Brunet To: Bui Duc Phuc Cc: Mark Brown , Liam Girdwood , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: meson: axg-tdm-formatter: Use guard() for mutex locks In-Reply-To: (Bui Duc Phuc's message of "Wed, 10 Jun 2026 23:27:09 +0700") References: <20260610102153.83367-1-phucduc.bui@gmail.com> <1j8q8mfte7.fsf@starbuckisacylon.baylibre.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 11 Jun 2026 10:10:35 +0200 Message-ID: <1jo6hhebus.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On mer. 10 juin 2026 at 23:27, Bui Duc Phuc wrote: > Hi Jerome, > > Thank you for your feedback, > >> >> I suppose it is OK but it does not seem to really clean anything and >> make the code easier to follow in that instance, from my perspective at >> least. >> >> If there is policy to systematically use guard() whenever >> possible then OK, otherwise it seems unnecessary. >> > > I have noticed that guard() has been adopted in several subsystems. > Since this appears to be the only place in the Meson ASoC code currently using > mutex_lock()/mutex_unlock(), I converted it for consistency with the > newer style. > > Going forward, should new Meson ASoC code use guard(), or should it continue > using the traditional mutex_lock()/mutex_unlock() pattern? Can't say if there is such policy either. IMO it should be more a case-by-case thing The code is not better or worse with the change but you went through the trouble of doing so, if Mark is fine with it, let's have it Reviewed-by: Jerome Brunet > > Best regards, > Phuc -- Jerome