From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84E84215181 for ; Wed, 14 May 2025 07:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747208354; cv=none; b=dUsdQo4wf7IShc5ArL3lsd642S3sMMh6injzVXtUprrzAGbUCEIENcYLioPKp6bTQAS5xeybNH89y7UWLpAlZddhp+irVORrSx2hAzN4bFmlUlYiVEqcOnzEztDdW4EsHxjaeEEjIg8TgcPjBO1XwXuZfq1y9i0whZeI3ArUd4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747208354; c=relaxed/simple; bh=kVQoQu1xI3xg82klmMxIsn7w8l/v5NLalZuo0VZW3bg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=LslsEYLmE4JgWm5HudUHd6GkQY4fX11diaWIIJaH8q9PXV0qZBnhLO+uJxJ1K/dQHllUKRu/ED83GUcpTjpV4nq3V9t1rjOAQ1cAGY5Ky15tmK/Czu7jEOi0rlZgY6GLXI9nUQ1vORwClZ6GuDuK5VgceZ/+BTxauwMusmln3Bc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=zwexy0jw; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="zwexy0jw" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a064a3e143so3725966f8f.3 for ; Wed, 14 May 2025 00:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1747208349; x=1747813149; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZVmGNhpPip+++PUOZC2sGERkflrjQCplFYAdCCvMfb8=; b=zwexy0jwybQ7JQtRI/froMEnI8PPBN8BOtZZTsW4OuKLyk8l4G+HfdeYjzNId5Ke9k SZ+6FVlrCtmqN9T7qNjvjKnHfhjywZloU6xvOXf2/SyGeYlhmmxkov3GQoLPplBShth/ ub4aMmJR/7TmQhp5pWB63s5fFZx5D6qS/T5tRqo4XcRb1tENcmnwzGnLeK4TFOj12MpT qXAXDT1kfMj9gbiS9AF9a45byMNnTstIPX48WFFYjL+1dfRBh5PJH0K5T1qgVaRedR7r vE/lLrvSoAiuJDKT0bScNYEOErxbUnKNkIahywvkN5FYdulanYbQVBF3YuDJvstW9r4n fYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747208349; x=1747813149; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZVmGNhpPip+++PUOZC2sGERkflrjQCplFYAdCCvMfb8=; b=dfK7gnSD6rO9zEG0vxXlDcYjpCgc4MRf+GgqWLwJnSrC6RcGrkjqOLOdv50G98bhQW rnO3nMtsc98pCZZ3fMqNLtOTEnxAYaKZftekKtrecBUiTBu5GichjwQoNgjukBGz+6JQ 11rHIM8y9RJEMsK6aNvKod2wQRtqbw/SyVwQLdmYdctebh/6iLlZdmxhmlqu5DLZmf0x LtrE3IOMnuyzNMaj4YDvgxTy1esXyT+V+/ZiReNiMIIY+AgACJ1O0Xe4VN/5WqemQt+w m+JjHMvRQGrdYiEG5D7cYygMJr1+msj3lzvPatX8MKr7LVGWZm3TcAuGnDQpaKNIIbJB tu1w== X-Forwarded-Encrypted: i=1; AJvYcCVKNtFZpHtHpnmVG4KnqEvr5bS5lweLDGr4Jyxhbjz9Z1dhUPvWe+FJIryk9JCKrfHxExLGTA5BuFkpub4=@vger.kernel.org X-Gm-Message-State: AOJu0YwskuQEsI5GBmgg4j9HbKYRVFjezv5SaAGR7lCjpzG5rTKiGTOF gecZ+QfgdgL3aO2xsKZFzeXmEgp0O/w5L+OMZAxSc87y3r6mJ4IPA3sIhlAB8sA= X-Gm-Gg: ASbGncvox8pnFVqNsmaZC34J8CivZ7DA1oGiW8cLh8cpjUiLbJOFe6SQSAVfpvM5On2 /Ol2uWj6Nqec6PutD5khaHL4ALNRj9xCzplQ2MgLhB0kDPzfiUjqIPIgfSHH2NBJrQu27lpyihE iul3sRjf0Mp/3a5eqb5R4enX0pdpmrCSq230DoiY30ZVBspwHGQda06J7gq6nnu61/CB1kDMJds JXgBHVQJxdPAl1Di7j3LZ2NIyqM99ANE7T97A0+XWwDKxwr6RbFQosQXncPsI3VoWyrR63CYLWN XrEaOOTIyjeWNI7Gp3BBvUU4V5Rtnwwiq94DH9YwW1EfWzQAllM= X-Google-Smtp-Source: AGHT+IG7CrNBn/EFtls8jFCa6+Od8EZnVpuoJGdjw4zpKMEd5j+UzCgUpQFM4d3fwpyVX79bArzG+Q== X-Received: by 2002:a05:6000:4201:b0:3a0:ac96:bd41 with SMTP id ffacd0b85a97d-3a3496c4024mr1989692f8f.27.1747208348669; Wed, 14 May 2025 00:39:08 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:3b94:a3ea:946a:aa90]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a1f5a2cf2bsm18503449f8f.80.2025.05.14.00.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 00:39:08 -0700 (PDT) From: Jerome Brunet To: Jian Hu Cc: Xianwei Zhao , Chuan Liu , Neil Armstrong , Kevin Hilman , "Stephen Boyd" , Michael Turquette , "Dmitry Rokosov" , robh+dt , Rob Herring , devicetree , linux-clk , linux-amlogic , linux-kernel , linux-arm-kernel Subject: Re: [PATCH v3 5/6] clk: meson: add MESON_PCLK_V2 for sys gate clock In-Reply-To: <20250509074825.1933254-6-jian.hu@amlogic.com> (Jian Hu's message of "Fri, 9 May 2025 07:48:23 +0000") References: <20250509074825.1933254-1-jian.hu@amlogic.com> <20250509074825.1933254-6-jian.hu@amlogic.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 14 May 2025 09:39:07 +0200 Message-ID: <1jzfffy738.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri 09 May 2025 at 07:48, Jian Hu wrote: > A new MESON_PCLK_V2 macro is introduced for the sys gate clock. Its parent > is an SCMI clock. It belongs to another clock controller, and the parent > configuration is different from that of MESON_PCLK. This avoids new macro > definition in the peripheral clock driver. > > Signed-off-by: Jian Hu > --- > drivers/clk/meson/clk-regmap.h | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/clk/meson/clk-regmap.h b/drivers/clk/meson/clk-regmap.h > index e365312da54e..61b8fc2d875f 100644 > --- a/drivers/clk/meson/clk-regmap.h > +++ b/drivers/clk/meson/clk-regmap.h This file is not meant for amlogic specific stuff. I know some found their way in regardless but that's being fixed > @@ -134,4 +134,28 @@ struct clk_regmap _name = { \ > > #define MESON_PCLK_RO(_name, _reg, _bit, _pname) \ > __MESON_PCLK(_name, _reg, _bit, &clk_regmap_gate_ro_ops, _pname) > + > +#define __MESON_PCLK_V2(_name, _reg, _bit, _ops, _pname) \ > +struct clk_regmap _name = { \ > + .data = &(struct clk_regmap_gate_data){ \ > + .offset = (_reg), \ > + .bit_idx = (_bit), \ > + }, \ > + .hw.init = &(struct clk_init_data) { \ > + .name = #_name, \ > + .ops = _ops, \ > + .parent_data = &(const struct clk_parent_data) { \ > + .fw_name = #_pname, \ > + }, \ > + .num_parents = 1, \ > + .flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED), \ > + }, \ > +} The proliferation of those macros has been going on for far too long, add using CLK_IGNORE_UNUSED inside is certainly a mistake I won't repeat. This will be part of more general clean-up that currently depends on a this [1] patch to go further. You'll have to be patient. [1]: https://lore.kernel.org/r/20250417-clk-hw-get-helpers-v1-0-7743e509612a@baylibre.com > + > +#define MESON_PCLK_V2(_name, _reg, _bit, _pname) \ > + __MESON_PCLK_V2(_name, _reg, _bit, &clk_regmap_gate_ops, _pname) > + > +#define MESON_PCLK_RO_V2(_name, _reg, _bit, _pname) \ > + __MESON_PCLK_V2(_name, _reg, _bit, &clk_regmap_gate_ro_ops, _pname) > + > #endif /* __CLK_REGMAP_H */ -- Jerome