From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B18752701A9 for ; Wed, 23 Apr 2025 09:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745400722; cv=none; b=h4gO28z8zeMj+abgR1Er28aYW9TBIl615bq4CnYfuYJUHujBykp1U5jLa2eMgNi0gniZpcuf1pm2L9RD1kkL9//pW3EwLLQnHzI/+D09b/MCpgqsnrZpq9hH3wqauy5HgKKKeLhGEKZqs547tKwbSmN9eN+k18Bw05J0pc4NQgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745400722; c=relaxed/simple; bh=cnjftqRTix1Iq4pNd26G3m4Fq6fJQhDX3rKnWMPwe/c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Lc7iB4hjYIK5kqDgFJpRh8oFtBfqOuoYcPbG/Yr1uF2EucUfLfjey5QXQAqyd1H9i7/rRQu51X8kKhuLe807Fa5uJqm0UiczqsX25S/q8u43qoAkYx098e96J6Rh/i/BDvZObkVkBjCT8dW8DMBbLZOLg4v3p/Yb71gzalLYDVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=P9K/UdFI; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="P9K/UdFI" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43690d4605dso49165415e9.0 for ; Wed, 23 Apr 2025 02:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745400718; x=1746005518; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=p/ibIxkHiQKL+uy9WgHCoDI8gDfvMqpX6jxocIOb2Ak=; b=P9K/UdFIJVhjamib2bLQMQc4Au7N4eY32dATE4WJFLvDgW4AXPly0uv1tiHgdOwWgq R4A8xDWBFBLPdylSx1QG4pXeWtSRxjc+uS+w3ZCLNSFDUsHwyc1A7Iim/wiNGpPtXLFG LelfAfxCJtbRPO8MuCc0GcS4IvlLQrz5Nb2UKb/B+m6AEm1dMHLBgGFP4bSTj7IZH7wc 8s+wTzPc4V6XWSeBtLCGjRnNpfzAAHCyJIWor26IDenCK2Nf9y7KSjb6akcIkc10XXS+ 9NzWQOxDnvz+4QKrORJ9+AiXtGEfkHDTTRv2r6+++WGlRnqDK2TowucXN0zt6985ZpgV Pvqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745400718; x=1746005518; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p/ibIxkHiQKL+uy9WgHCoDI8gDfvMqpX6jxocIOb2Ak=; b=gtywRwrTJqO98Qhz/bk4vzPRbaixDmJIjSwf4XGEAqSef53NFp7GcL4DnEOMlZmdmG BhESlJB1Tl7j/hLnxjuxnZgFl4puz5yiiHEF7XsA0UWsjev+5BnWat/uQjhUBxTTQdyM Kt2I/UtK8fJJfkoRK05D0CQ49PcYPu8UjebrbAbfKrapRq8BFXAN2h+Un/vLBPwqGDa0 PZ+DwjJGfbgkfTO/Iz229RxT/ZXVCQdFP7cuMkVkeiFJ+rVWvRICjV+gaE8Fu1+OmS/F kYbS//vJ2VP6ugW5Y99HxeRNq9Z7Jw/Xl3MlUXvMyPKx7qzhAYez2tsQ/94vFgngDp1m jmvw== X-Forwarded-Encrypted: i=1; AJvYcCXuiTBgT0fv5aT+D3p7j3WDMK4cLCAAKF5Z0FyWWdpd0MKK6OHFvwH9jd9RE4O+WAx1Ac2cTeqjvozaRmc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/43/yp75jgMlc4N2vgcwmd/ZuZZydjQlkHLPsQetIj/AkiKd3 LePow4CBDGSBFWW4u9fzhj/aw/ZISrOTBPJVH3/W6ffLws3lIsW7zZO1rstYAOM= X-Gm-Gg: ASbGncuZJSIRj8d5x1YpVDQZ6lTyqeYquESDq9wNB61PfuByXe44+Czh2wqm0OKy58u V39Mwl/AxLPiKpEHIVCftorXFVxU8u40oBkqdnHZLRMcdz/b+u0gClVUDB7H/SLW/U7iFjiay/3 v/b3Lr5vU7NAS4B68tt/IxbqXSOmf4l5CHQxvc9mmLZhd6ZEvVowxF/GzDhPGWkeGRAy0yQS5Gj CFcrOeX62ff1VvSMqNCls+ozKoIm/oP4GpsB8HaLW0cw2AcMhZM9S4iYtjan6NnlU61wgfyAdG4 26PEAI/O8/5IOuIAQKrrxNBMQSf9FaSX+nPZz7Cu X-Google-Smtp-Source: AGHT+IFg6enZe+1trj27dPXdi1sR5KVmpei5QX91LSKw+3qUguME3MQq9BDTJG3uhoa8q4Oe51KzZg== X-Received: by 2002:a05:6000:228a:b0:39d:6f2b:e74d with SMTP id ffacd0b85a97d-39efbae02a8mr16225715f8f.39.1745400717823; Wed, 23 Apr 2025 02:31:57 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:cf73:b178:1f43:c630]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39efa4206fasm17848060f8f.2.2025.04.23.02.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 02:31:57 -0700 (PDT) From: Jerome Brunet To: Dan Carpenter Cc: Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , "Rafael J. Wysocki" , Danilo Krummrich , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] driver core: auxiliary bus: Fix IS_ERR() vs NULL check in __devm_auxiliary_device_create() In-Reply-To: (Dan Carpenter's message of "Wed, 23 Apr 2025 11:17:51 +0300") References: User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 23 Apr 2025 11:31:56 +0200 Message-ID: <1jzfg7nrzn.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed 23 Apr 2025 at 11:17, Dan Carpenter wrote: > The auxiliary_device_create() function returns NULL. It doesn't return > error pointers. Update the checking to match. > > Fixes: eaa0d30216c1 ("driver core: auxiliary bus: add device creation helpers") > Signed-off-by: Dan Carpenter Thanks for catching this mistake Dan. The thing was initially setup to return error code. Greg asked to simply return NULL on error and I forgot to re-align the devm variant. So I think the fix should be to check for NULL as you did but return NULL too so it is aligned with non-devm variant. If you wish, I can handle a v2. > --- > drivers/base/auxiliary.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c > index 810b6105a75d..61b876d90b7f 100644 > --- a/drivers/base/auxiliary.c > +++ b/drivers/base/auxiliary.c > @@ -491,8 +491,8 @@ struct auxiliary_device *__devm_auxiliary_device_create(struct device *dev, > int ret; > > auxdev = auxiliary_device_create(dev, modname, devname, platform_data, id); > - if (IS_ERR(auxdev)) > - return auxdev; > + if (!auxdev) > + return ERR_PTR(-ENOMEM); > > ret = devm_add_action_or_reset(dev, auxiliary_device_destroy, > auxdev); -- Jerome