public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] address-space identification for /proc
@ 2000-10-26 22:45 Jeremy Fitzhardinge
  2000-10-26 22:52 ` Jeremy Fitzhardinge
  0 siblings, 1 reply; 4+ messages in thread
From: Jeremy Fitzhardinge @ 2000-10-26 22:45 UTC (permalink / raw)
  To: Linux Kernel, linus


[-- Attachment #1.1: Type: text/plain, Size: 313 bytes --]

Hi,

/proc has no way to indicate whether tasks share an address space.
This one-liner patch adds a new ASID: field to /proc/<pid>/status so
there's some way to see address-space sharing between tasks.

While this is hardly a bug-fix, it is a pretty useful thing to know
which is otherwise completely absent.

	J

[-- Attachment #1.2: asid.diff --]
[-- Type: text/plain, Size: 296 bytes --]

--- ../2.3/fs/proc/array.c	Mon Oct  9 17:03:53 2000
+++ linux/fs/proc/array.c	Thu Oct 26 15:20:52 2000
@@ -294,6 +294,7 @@
 	for(line=0;(len=sprintf_regs(line,buffer,task,NULL,NULL))!=0;line++)
 		buffer+=len;
 #endif
+	buffer += sprintf("ASID: %p\n", mm);
 	return buffer - orig;
 }
 

[-- Attachment #2: Type: application/pgp-signature, Size: 240 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] address-space identification for /proc
  2000-10-26 22:45 [PATCH] address-space identification for /proc Jeremy Fitzhardinge
@ 2000-10-26 22:52 ` Jeremy Fitzhardinge
  2000-10-26 23:01   ` Johannes Erdfelt
  0 siblings, 1 reply; 4+ messages in thread
From: Jeremy Fitzhardinge @ 2000-10-26 22:52 UTC (permalink / raw)
  To: Linux Kernel, linus

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

On Thu, Oct 26, 2000 at 03:45:27PM -0700, I wrote:
> +	buffer += sprintf("ASID: %p\n", mm);

Obviously, this should be:

+	buffer += sprintf("ASID:\t%p\n", mm);

for consistency.

	J

[-- Attachment #2: Type: application/pgp-signature, Size: 240 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] address-space identification for /proc
  2000-10-26 22:52 ` Jeremy Fitzhardinge
@ 2000-10-26 23:01   ` Johannes Erdfelt
  2000-10-27  1:21     ` Jeremy Fitzhardinge
  0 siblings, 1 reply; 4+ messages in thread
From: Johannes Erdfelt @ 2000-10-26 23:01 UTC (permalink / raw)
  To: Jeremy Fitzhardinge, Linux Kernel, linus

On Thu, Oct 26, 2000, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> On Thu, Oct 26, 2000 at 03:45:27PM -0700, I wrote:
> > +	buffer += sprintf("ASID: %p\n", mm);
> 
> Obviously, this should be:
> 
> +	buffer += sprintf("ASID:\t%p\n", mm);

and even more obvious:

+	buffer += sprintf(buffer, "ASID:\t%p\n", mm);

Actually putting it into the buffer would be useful as well :)

JE

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] address-space identification for /proc
  2000-10-26 23:01   ` Johannes Erdfelt
@ 2000-10-27  1:21     ` Jeremy Fitzhardinge
  0 siblings, 0 replies; 4+ messages in thread
From: Jeremy Fitzhardinge @ 2000-10-27  1:21 UTC (permalink / raw)
  To: Johannes Erdfelt; +Cc: Linux Kernel, linus

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

On Thu, Oct 26, 2000 at 07:01:26PM -0400, Johannes Erdfelt wrote:
> and even more obvious:
> 
> +	buffer += sprintf(buffer, "ASID:\t%p\n", mm);
> 
> Actually putting it into the buffer would be useful as well :)

That serves me right for hand-editing patches.

	J
--
Repeat to self: I am not Linus

[-- Attachment #2: Type: application/pgp-signature, Size: 240 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2000-10-27  1:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2000-10-26 22:45 [PATCH] address-space identification for /proc Jeremy Fitzhardinge
2000-10-26 22:52 ` Jeremy Fitzhardinge
2000-10-26 23:01   ` Johannes Erdfelt
2000-10-27  1:21     ` Jeremy Fitzhardinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox