Re: patch: atapi dvd-ram support

[Jens Axboe <axboe@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On Sun, Oct 29 2000, Hisaaki Shibata wrote:
> > Ok, does /proc/sys/dev/cdrom/info list DVD-RAM as a capability?
> 
> Yes.
> I think it seems good.
> 
> # more info 
> CD-ROM information, Id: cdrom.c 3.12 2000/10/22
> 
> Can write DVD-RAM:      1

So far, so good.

> Should I set any flags to permit write a DVD-RAM media ?

No, as I said it should detect it automatically. But d'oh, I
just realised that it is set too soon... Sorry, try with this
patch.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs

[-- Attachment #2: dvdram-ro_fix.diff --]
[-- Type: text/plain, Size: 732 bytes --]

--- drivers/block/ide-cd.c~	Sat Oct 28 20:09:03 2000
+++ drivers/block/ide-cd.c	Sat Oct 28 20:09:23 2000
@@ -2597,8 +2597,6 @@
 	int minor = drive->select.b.unit << PARTN_BITS;
 	int nslots, ro;
 
-	ro = !CDROM_CONFIG_FLAGS(drive)->dvd_ram;
-	set_device_ro(MKDEV(HWIF(drive)->major, minor), ro);
 	set_blocksize(MKDEV(HWIF(drive)->major, minor), CD_FRAMESIZE);
 
 	drive->special.all	= 0;
@@ -2718,6 +2716,9 @@
 	info->start_seek	= 0;
 
 	nslots = ide_cdrom_probe_capabilities (drive);
+
+	ro = !CDROM_CONFIG_FLAGS(drive)->dvd_ram;
+	set_device_ro(MKDEV(HWIF(drive)->major, minor), ro);
 
 	if (ide_cdrom_register (drive, nslots)) {
 		printk ("%s: ide_cdrom_setup failed to register device with the cdrom driver.\n", drive->name);