Re: patch: atapi dvd-ram support

Re: patch: atapi dvd-ram support

[Hisaaki Shibata]

Hello

I did patch 2.2.17 tree with dvd-ram-2217p17.diff.bz2.

At that time, following patch is rejected.
I think these lines should be removed from patchs.

	@@ -1329,7 +1369,7 @@
	 static
	  void cdrom_sleep (int time)
	   {
	   -       current->state = TASK_INTERRUPTIBLE;
	   +       __set_current_state(TASK_INTERRUPTIBLE);
	           schedule_timeout(time);
	    }

After removing these, I could make bzImage.

But I could not mkudf nor mkext2fs to my ATAPI 9.4GB new DVD-RAM drive.

dmesg shows;
--------------------------------------------------------------------------
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
PIIX4: IDE controller on PCI bus 00 dev 39
PIIX4: chipset revision 1
PIIX4: not 100% native mode: will probe irqs later
    ide0: BM-DMA at 0xf000-0xf007, BIOS settings: hda:pio, hdb:pio
    ide1: BM-DMA at 0xf008-0xf00f, BIOS settings: hdc:pio, hdd:pio
PDC20262: IDE controller on PCI bus 00 dev 60
PDC20262: chipset revision 1
PDC20262: not 100% native mode: will probe irqs later
PDC20262: ROM enabled at 0xe7000000
PDC20262: (U)DMA Burst Bit ENABLED Primary PCI Mode Secondary PCI Mode.
PDC20262: FORCING PRIMARY MODE BIT 0x00 -> 0x01 MASTER
PDC20262: FORCING SECONDARY MODE BIT 0x00 -> 0x01 MASTER
    ide2: BM-DMA at 0xec00-0xec07, BIOS settings: hde:DMA, hdf:pio
    ide3: BM-DMA at 0xec08-0xec0f, BIOS settings: hdg:DMA, hdh:pio
hdc: HITACHI DVD-RAM GF-2000, ATAPI CDROM drive
hde: IBM-DTLA-305020, ATA DISK drive
hdg: IBM-DTLA-305020, ATA DISK drive
ide1 at 0x170-0x177,0x376 on irq 15
ide2 at 0xdc00-0xdc07,0xe002 on irq 16
ide3 at 0xe400-0xe407,0xe802 on irq 16
hde: IBM-DTLA-305020, 19623MB w/380kB Cache, CHS=39870/16/63, UDMA(66)
hdg: IBM-DTLA-305020, 19623MB w/380kB Cache, CHS=39870/16/63, UDMA(66)

[SNIP]

hdc: ATAPI DVD-ROM DVD-RAM drive, 512kB Cache, UDMA(33)
Uniform CD-ROM driver Revision: 3.12
VFS: Disk change detected on device ide1(22,0)
Uniform CD-ROM driver unloaded
--------------------------------------------------------------------------

/proc/ide/hdc/media shows;
cdrom

How can I read/write DVD-RAM media like MO drive?

I can read/write ATAPI 5.2GB DVD-RAM media with 2.2.16 ide-scsi mode in ext2fs.

Best Regards,


> I've put up patches for 2.2 and 2.4 adding native ATAPI dvd-ram support.
> The 2.2 patch is completely untested, but the 2.4 version appears to
> work well.
> 
> *.kernel.org/pub/linux/kernel/people/axboe/dvdram

-- 
 WWWWW  shibata@luky.org
 |O-O|  Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233    IRC: #luky
   ~    http://his.luky.org/ last update:2000.3.12
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Andre Hedrick]

hdparm -r0 /dev/hdc

smsc:/proc/ide/hdc # cat model driver media
MATSHITADVD-RAM LF-D210
ide-cdrom version 4.99
cdrom

smsc:/proc/ide/hdc # hdparm -r0 /dev/hdc

/dev/hdc:
 setting readonly to 0 (off)
 readonly     =  0 (off)

smsc:/ # mke2fs -b 2048 /dev/hdc -m 0
mke2fs 1.18, 11-Nov-1999 for EXT2 FS 0.5b, 95/08/09
Filesystem label=
OS type: Linux
Block size=2048 (log=1)
Fragment size=2048 (log=1)
561152 inodes, 2236704 blocks
0 blocks (0.00%) reserved for the super user
First data block=0
137 block groups
16384 blocks per group, 16384 fragments per group
4096 inodes per group
Superblock backups stored on blocks:
        16384, 49152, 81920, 114688, 147456, 409600, 442368, 802816, 1327104,
        2048000

Writing inode tables: done
Writing superblocks and filesystem accounting information: done

That is how it is DONE!

On Sat, 28 Oct 2000, Hisaaki Shibata wrote:

> Hello
> 
> I did patch 2.2.17 tree with dvd-ram-2217p17.diff.bz2.
> 
> At that time, following patch is rejected.
> I think these lines should be removed from patchs.
> 
> 	@@ -1329,7 +1369,7 @@
> 	 static
> 	  void cdrom_sleep (int time)
> 	   {
> 	   -       current->state = TASK_INTERRUPTIBLE;
> 	   +       __set_current_state(TASK_INTERRUPTIBLE);
> 	           schedule_timeout(time);
> 	    }
> 
> After removing these, I could make bzImage.
> 
> But I could not mkudf nor mkext2fs to my ATAPI 9.4GB new DVD-RAM drive.
> 
> dmesg shows;
> --------------------------------------------------------------------------
> ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
> PIIX4: IDE controller on PCI bus 00 dev 39
> PIIX4: chipset revision 1
> PIIX4: not 100% native mode: will probe irqs later
>     ide0: BM-DMA at 0xf000-0xf007, BIOS settings: hda:pio, hdb:pio
>     ide1: BM-DMA at 0xf008-0xf00f, BIOS settings: hdc:pio, hdd:pio
> PDC20262: IDE controller on PCI bus 00 dev 60
> PDC20262: chipset revision 1
> PDC20262: not 100% native mode: will probe irqs later
> PDC20262: ROM enabled at 0xe7000000
> PDC20262: (U)DMA Burst Bit ENABLED Primary PCI Mode Secondary PCI Mode.
> PDC20262: FORCING PRIMARY MODE BIT 0x00 -> 0x01 MASTER
> PDC20262: FORCING SECONDARY MODE BIT 0x00 -> 0x01 MASTER
>     ide2: BM-DMA at 0xec00-0xec07, BIOS settings: hde:DMA, hdf:pio
>     ide3: BM-DMA at 0xec08-0xec0f, BIOS settings: hdg:DMA, hdh:pio
> hdc: HITACHI DVD-RAM GF-2000, ATAPI CDROM drive
> hde: IBM-DTLA-305020, ATA DISK drive
> hdg: IBM-DTLA-305020, ATA DISK drive
> ide1 at 0x170-0x177,0x376 on irq 15
> ide2 at 0xdc00-0xdc07,0xe002 on irq 16
> ide3 at 0xe400-0xe407,0xe802 on irq 16
> hde: IBM-DTLA-305020, 19623MB w/380kB Cache, CHS=39870/16/63, UDMA(66)
> hdg: IBM-DTLA-305020, 19623MB w/380kB Cache, CHS=39870/16/63, UDMA(66)
> 
> [SNIP]
> 
> hdc: ATAPI DVD-ROM DVD-RAM drive, 512kB Cache, UDMA(33)
> Uniform CD-ROM driver Revision: 3.12
> VFS: Disk change detected on device ide1(22,0)
> Uniform CD-ROM driver unloaded
> --------------------------------------------------------------------------
> 
> /proc/ide/hdc/media shows;
> cdrom
> 
> How can I read/write DVD-RAM media like MO drive?
> 
> I can read/write ATAPI 5.2GB DVD-RAM media with 2.2.16 ide-scsi mode in ext2fs.
> 
> Best Regards,
> 
> 
> > I've put up patches for 2.2 and 2.4 adding native ATAPI dvd-ram support.
> > The 2.2 patch is completely untested, but the 2.4 version appears to
> > work well.
> > 
> > *.kernel.org/pub/linux/kernel/people/axboe/dvdram
> 
> -- 
>  WWWWW  shibata@luky.org
>  |O-O|  Hisaaki Shibata
> 0(mmm)0 P-mail: 070-5419-3233    IRC: #luky
>    ~    http://his.luky.org/ last update:2000.3.12
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> Please read the FAQ at http://www.tux.org/lkml/
> 

Andre Hedrick
The Linux ATA/IDE guy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Jens Axboe]

On Fri, Oct 27 2000, Andre Hedrick wrote:
> hdparm -r0 /dev/hdc

[snip]

> That is how it is DONE!

This is not necessary, the ide-cd driver will set the read-only
flag appropriately depending on the device type detected.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Andre Hedrick]

On Sat, 28 Oct 2000, Jens Axboe wrote:

> This is not necessary, the ide-cd driver will set the read-only
> flag appropriately depending on the device type detected.

This may not be the best option as the default.
If a dvd-ram is used for backup you may not always want it in RW mode.
Just a thought.

Andre Hedrick
The Linux ATA/IDE guy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Jens Axboe]

On Sat, Oct 28 2000, Andre Hedrick wrote:
> > This is not necessary, the ide-cd driver will set the read-only
> > flag appropriately depending on the device type detected.
> 
> This may not be the best option as the default.
> If a dvd-ram is used for backup you may not always want it in RW mode.
> Just a thought.

Just mount it ro then?

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Jens Axboe]

On Sat, Oct 28 2000, Hisaaki Shibata wrote:
> I did patch 2.2.17 tree with dvd-ram-2217p17.diff.bz2.
> 
> At that time, following patch is rejected.
> I think these lines should be removed from patchs.
> 
> 	@@ -1329,7 +1369,7 @@
> 	 static
> 	  void cdrom_sleep (int time)
> 	   {
> 	   -       current->state = TASK_INTERRUPTIBLE;
> 	   +       __set_current_state(TASK_INTERRUPTIBLE);
> 	           schedule_timeout(time);
> 	    }
> 
> After removing these, I could make bzImage.

Weird, should not reject. Oh well.

> But I could not mkudf nor mkext2fs to my ATAPI 9.4GB new DVD-RAM drive.

What do you mean? What happened? strace of mke2fs of mkudf would
be nice to have.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Hisaaki Shibata]

Thanks, Axboe

> > But I could not mkudf nor mkext2fs to my ATAPI 9.4GB new DVD-RAM drive.
> 
> What do you mean? What happened? strace of mke2fs of mkudf would
> be nice to have.

My system said it is not permited because it is read only.

execve("/sbin/mke2fs", ["/sbin/mke2fs", "/dev/hdc"], [/* 19 vars */]) = 0
brk(0)                                  = 0x804dd80
old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40013000
open("/etc/ld.so.preload", O_RDONLY)    = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY)      = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=19214, ...}) = 0
old_mmap(NULL, 19214, PROT_READ, MAP_PRIVATE, 3, 0) = 0x40014000
close(3)                                = 0
open("/lib/libext2fs.so.2", O_RDONLY)   = 3
fstat(3, {st_mode=S_IFREG|0755, st_size=83284, ...}) = 0
read(3, "\177ELF\1\1\1\0\0\0\0\0\0\0\0\0\3\0\3\0\1\0\0\0\2146\0"..., 4096) = 4096
old_mmap(NULL, 71696, PROT_READ|PROT_EXEC, MAP_PRIVATE, 3, 0) = 0x40019000
mprotect(0x4002a000, 2064, PROT_NONE)   = 0
old_mmap(0x4002a000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED, 3, 0x10000) = 0x4002a000
close(3)                                = 0
open("/lib/libcom_err.so.2", O_RDONLY)  = 3
fstat(3, {st_mode=S_IFREG|0755, st_size=8057, ...}) = 0
read(3, "\177ELF\1\1\1\0\0\0\0\0\0\0\0\0\3\0\3\0\1\0\0\0\230\t\0"..., 4096) = 4096


And  /proc/ide/hdc/media says "cdrom". Is it OK?


Best Regards,

-- 
 WWWWW  shibata@luky.org
 |O-O|  Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233    IRC: #luky
   ~    http://his.luky.org/ last update:2000.3.12
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Jens Axboe]

On Sat, Oct 28 2000, Hisaaki Shibata wrote:
> > > But I could not mkudf nor mkext2fs to my ATAPI 9.4GB new DVD-RAM drive.
> > 
> > What do you mean? What happened? strace of mke2fs of mkudf would
> > be nice to have.
> 
> My system said it is not permited because it is read only.

[snip]

Ok, does /proc/sys/dev/cdrom/info list DVD-RAM as a capability?

> And  /proc/ide/hdc/media says "cdrom". Is it OK?

Yes, that is fine.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Hisaaki Shibata]

Thank you, again.

> On Sat, Oct 28 2000, Hisaaki Shibata wrote:
> > > > But I could not mkudf nor mkext2fs to my ATAPI 9.4GB new DVD-RAM drive.
> > > 
> > > What do you mean? What happened? strace of mke2fs of mkudf would
> > > be nice to have.
> > 
> > My system said it is not permited because it is read only.
> 
> [snip]
> 
> Ok, does /proc/sys/dev/cdrom/info list DVD-RAM as a capability?

Yes.
I think it seems good.

# more info 
CD-ROM information, Id: cdrom.c 3.12 2000/10/22

drive name:             hdc
drive speed:            0
drive # of slots:       1
Can close tray:         1
Can open tray:          1
Can lock tray:          1
Can change speed:       1
Can select disk:        0
Can read multisession:  1
Can read MCN:           1
Reports media changed:  1
Can play audio:         1
Can write CD-R:         0
Can write CD-RW:        0
Can read DVD:           1
Can write DVD-R:        0
Can write DVD-RAM:      1

> > And  /proc/ide/hdc/media says "cdrom". Is it OK?
> 
> Yes, that is fine.

OK.

Should I set any flags to permit write a DVD-RAM media ?

Best Regards,

-- 
 WWWWW  shibata@luky.org
 |O-O|  Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233    IRC: #luky
   ~    http://his.luky.org/ last update:2000.3.12
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Jens Axboe]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On Sun, Oct 29 2000, Hisaaki Shibata wrote:
> > Ok, does /proc/sys/dev/cdrom/info list DVD-RAM as a capability?
> 
> Yes.
> I think it seems good.
> 
> # more info 
> CD-ROM information, Id: cdrom.c 3.12 2000/10/22
> 
> Can write DVD-RAM:      1

So far, so good.

> Should I set any flags to permit write a DVD-RAM media ?

No, as I said it should detect it automatically. But d'oh, I
just realised that it is set too soon... Sorry, try with this
patch.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs

[-- Attachment #2: dvdram-ro_fix.diff --]
[-- Type: text/plain, Size: 732 bytes --]

--- drivers/block/ide-cd.c~	Sat Oct 28 20:09:03 2000
+++ drivers/block/ide-cd.c	Sat Oct 28 20:09:23 2000
@@ -2597,8 +2597,6 @@
 	int minor = drive->select.b.unit << PARTN_BITS;
 	int nslots, ro;
 
-	ro = !CDROM_CONFIG_FLAGS(drive)->dvd_ram;
-	set_device_ro(MKDEV(HWIF(drive)->major, minor), ro);
 	set_blocksize(MKDEV(HWIF(drive)->major, minor), CD_FRAMESIZE);
 
 	drive->special.all	= 0;
@@ -2718,6 +2716,9 @@
 	info->start_seek	= 0;
 
 	nslots = ide_cdrom_probe_capabilities (drive);
+
+	ro = !CDROM_CONFIG_FLAGS(drive)->dvd_ram;
+	set_device_ro(MKDEV(HWIF(drive)->major, minor), ro);
 
 	if (ide_cdrom_register (drive, nslots)) {
 		printk ("%s: ide_cdrom_setup failed to register device with the cdrom driver.\n", drive->name);

Re: patch: atapi dvd-ram support

[Hisaaki Shibata]

Thanks again.

> > > Ok, does /proc/sys/dev/cdrom/info list DVD-RAM as a capability?

> > CD-ROM information, Id: cdrom.c 3.12 2000/10/22
> > 
> > Can write DVD-RAM:      1
> 
> So far, so good.

:-)

> > Should I set any flags to permit write a DVD-RAM media ?
> 
> No, as I said it should detect it automatically. But d'oh, I
> just realised that it is set too soon... Sorry, try with this
> patch.

Thank you for your quick response.

I tried the patch.
But kernel said Oops both fdisk /dev/hdc and
dd if=/dev/zero of=/dev/hdc bs=2048 count=1 .

strace dd if=/dev/zero of=/dev/hdc bs=2048 count=1 shows
-----------------------------------------------------------------------------
[root@celto shibata]# strace  dd if=/dev/zero of=/dev/hdc bs=2048 count=1
execve("/bin/dd", ["dd", "if=/dev/zero", "of=/dev/hdc", "bs=2048", "count=1"], [/* 19 vars */]) = 0
brk(0)                                  = 0x80504a8
old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40013000
open("/etc/ld.so.preload", O_RDONLY)    = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY)      = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=19214, ...}) = 0
old_mmap(NULL, 19214, PROT_READ, MAP_PRIVATE, 3, 0) = 0x40014000
close(3)                                = 0
open("/lib/libc.so.6", O_RDONLY)        = 3
fstat(3, {st_mode=S_IFREG|0755, st_size=5224080, ...}) = 0
read(3, "\177ELF\1\1\1\0\0\0\0\0\0\0\0\0\3\0\3\0\1\0\0\0(\215\1"..., 4096) = 4096
old_mmap(NULL, 941692, PROT_READ|PROT_EXEC, MAP_PRIVATE, 3, 0) = 0x40019000
mprotect(0x400f7000, 32380, PROT_NONE)  = 0
old_mmap(0x400f7000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED, 3, 0xdd000) = 0x400f7000
old_mmap(0x400fc000, 11900, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x400fc000
close(3)                                = 0
munmap(0x40014000, 19214)               = 0
personality(PER_LINUX)                  = 0
getpid()                                = 709
brk(0)                                  = 0x80504a8
brk(0x80504e0)                          = 0x80504e0
brk(0x8051000)                          = 0x8051000
close(0)                                = 0
open("/dev/zero", O_RDONLY|O_LARGEFILE) = 0
close(1)                                = 0
open("/dev/hdc", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = -1 ENOSYS (Function not implemented)
open("/dev/hdc", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = -1 ENOSYS (Function not implemented)
open("/dev/hdc", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = 1
rt_sigaction(SIGINT, NULL, {SIG_DFL}, 8) = 0
rt_sigaction(SIGINT, {0x804adec, [], 0x4000000}, NULL, 8) = 0
rt_sigaction(SIGQUIT, NULL, {SIG_DFL}, 8) = 0
rt_sigaction(SIGQUIT, {0x804adec, [], 0x4000000}, NULL, 8) = 0
rt_sigaction(SIGPIPE, NULL, {SIG_DFL}, 8) = 0
rt_sigaction(SIGPIPE, {0x804adec, [], 0x4000000}, NULL, 8) = 0
rt_sigaction(SIGUSR1, NULL, {SIG_DFL}, 8) = 0
rt_sigaction(SIGUSR1, {0x804aeac, [], 0x4000000}, NULL, 8) = 0
brk(0x8054000)                          = 0x8054000
read(0, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 2048) = 2048
write(1, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 2048) = 2048
write(2, "1+0 records in\n", 151+0 records in
)        = 15
write(2, "1+0 records out\n", 161+0 records out
)       = 16
close(0)                                = 0
close(1

-----------------------------------------------------------------------------
After showing above strace message in a few seconds, kernel panic happened.

I can not see some head line of Oops messages. Sorry.

Please let me test more patches. I will keep up with you.

Best Regards,

-- 
 WWWWW  shibata@luky.org
 |O-O|  Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233    IRC: #luky
   ~    http://his.luky.org/ last update:2000.3.12
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Jens Axboe]

On Sun, Oct 29 2000, Hisaaki Shibata wrote:
> I tried the patch.
> But kernel said Oops both fdisk /dev/hdc and
> dd if=/dev/zero of=/dev/hdc bs=2048 count=1 .

> After showing above strace message in a few seconds, kernel panic happened.
> 
> I can not see some head line of Oops messages. Sorry.

Is there any way for you to grab those messages, maybe with a serial
console? I'd really like to see them.

> Please let me test more patches. I will keep up with you.

Or you could try the 2.4 version, as I said originally the 2.2 patch
hasn't been tested at all. It would be nice to know if that works
for you, as I may have screwed up the backport a bit.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Hisaaki Shibata]

Hello again,

> > I tried the patch.
> > But kernel said Oops both fdisk /dev/hdc and
> > dd if=/dev/zero of=/dev/hdc bs=2048 count=1 .
> 
> > After showing above strace message in a few seconds, kernel panic happened.
> > 
> > I can not see some head line of Oops messages. Sorry.
> 
> Is there any way for you to grab those messages, maybe with a serial
> console? I'd really like to see them.

By using serial console, I get messages for you ;-)


In case of doing "dd if=/dev/zero of=/dev/hdc bs=2048 count=1".
----------------------------------------------------------------------------
hdc: ATAPI DVD-ROM DVD-RAM drive, 512kB Cache, UDMA(33)
hdc: timeout waiting for DMA
ide_dmaproc: chipset supported ide_dma_timeout func only: 14
hdc: irq timeout: status=0x7f { DriveReady DeviceFault SeekComplete DataRequest CorrectedError Index Error }                        
hdc: irq timeout: error=0x7f
hdc: DMA disabled
hdc: ATAPI reset complete
Unable to handle kernel NULL pointer dereference at virtual address 00000014
current->tss.cr3 = 00101000, %cr3 = 00101000
*pde = 00000000
Oops: 0000
CPU:    0
EIP:    0010:[<d8ab07a1>]
EFLAGS: 00010292
eax: 00000000   ebx: c0240318   ecx: 00000003   edx: d8ab0788
esi: d58a2600   edi: 00000080   ebp: 00000001   esp: c020dd74
ds: 0018   es: 0018   ss: 0018
Process swapper (pid: 0, process nr: 0, stackpage=c020d000)
Stack: 00000080 00000001 c0240318 d58a2600 00008000 00000001 c0229c20 00000286
       00feaac0 0080a3a4 c022d900 d2f157a0 c0229c20 d8aaf81c c020dde8 c0240318
       00000000 d8aaf917 c0240318 00000000 00000188 c019961a 00000000 d58a2600
Call Trace: [<d8aaf81c>] [<d8aaf917>] [<c019961a>] [<c01c5d49>] [<d8ab0832>] [<d8ab0788>] [<d8ab094d>]
       [<c019aa66>] [<c019adc0>] [<c019adc6>] [<c019b19e>] [<c019af74>] [<c011123b>] [<c0115775>] [<c0111994>]
       [<c0111946>] [<c011c99d>] [<c0106000>] [<c010ca89>] [<c010caa0>] [<c010b4f8>] [<c0106000>] [<c0108a11>]
       [<c0106000>] [<c010607c>] [<c0106000>] [<c01001ae>]
Code: 8b 50 14 8b 70 10 8d 44 24 34 89 44 24 18 c1 ee 02 31 c0 8b
Aiee, killing interrupt handler
Kernel panic: Attempted to kill the idle task!
In swapper task - not syncing   
----------------------------------------------------------------------------

In case of "/sbin/fdisk /dev/hdc" is a little bit different.


[root@celto shibata]# /sbin/fdisk /dev/hdc
Device contains neither a valid DOS partition table, nor Sun or SGI disklabel
Building a new DOS disklabel. Changes will remain in memory only,
until you decide to write them. After that, of course, the previous
content won't be recoverable.


Command (m for help): p

Disk /dev/hdc: 1 heads, 8946816 sectors, 1 cylinders
Units = cylinders of 8946816 * 512 bytes

   Device Boot    Start       End    Blocks   Id  System

Command (m for help): n
Command action
   e   extended
   p   primary partition (1-4)
p
Partition number (1-4): 1
First cylinder (1-1, default 1): 1

Command (m for help): p

Disk /dev/hdc: 1 heads, 8946816 sectors, 1 cylinders
Units = cylinders of 8946816 * 512 bytes

   Device Boot    Start       End    Blocks   Id  System
/dev/hdc1             1         1   4473407+  83  Linux
Partition 1 has different physical/logical endings:
     phys=(512, 0, 0) logical=(0, 0, 8946816)
Partition 1 does not end on cylinder boundary:
     phys=(512, 0, 0) should be (512, 0, 8946816)

Command (m for help): w
The partition table has been altered!

Calling ioctl() to re-read partition table.
----------------------------------------------------------------------------
hdc: ATAPI DVD-ROM DVD-RAM drive, 512kB Cache, UDMA(33)
Unable to handle kernel NULL pointer dereference at virtual address 0000002c
current->tss.cr3 = 13185000, %cr3 = 13185000
*pde = 00000000
Oops: 0000
CPU:    1
EIP:    0010:[<c01a7b0a>]
EFLAGS: 00010292
eax: 00000000   ebx: 0000f008   ecx: 128e395c   edx: c02402d8
esi: 00000001   edi: d7fda800   ebp: c0240318   esp: d3013bec
ds: 0018   es: 0018   ss: 0018
Process fdisk (pid: 704, process nr: 60, stackpage=d3013000)
Stack: c02402d8 c0240318 00000002 00000087 c017d6bc c01c5d49 000001c2 00000000
       c016afd4 c01a7fde c0240318 00000001 00000001 c019a771 c0240318 d5960e00
       00008000 00000001 c0240318 d5960e00 00000000 00000001 c02296f8 00000286
Call Trace: [<c017d6bc>] [<c01c5d49>] [<c016afd4>] [<c01a7fde>] [<c019a771>] [<c01a9f82>] [<d8aaf81c>]
       [<d8aaf85a>] [<c019961a>] [<c01c5d49>] [<d8ab0832>] [<d8ab0788>] [<c012c44f>] [<d8ab094d>] [<c019aa66>]
       [<c012c44f>] [<c019adc6>] [<c01989cf>] [<c019ae8b>] [<c0197bb0>] [<d880164c>] [<c012b631>] [<d880164c>]
       [<c0164430>] [<d8800000>] [<d8801674>] [<d8801680>] [<c0167623>] [<d880164c>] [<d8820e3c>] [<c0166933>]
       [<c01d99cf>] [<c0159d77>] [<c012e95c>] [<c012b8f7>] [<c012b8ee>] [<c01b8aa4>] [<c012b94d>] [<c010a47d>]
       [<c010a344>]
Code: 8b 58 2c c7 44 24 1c 00 00 00 00 85 db 75 13 8b 70 20 8b 48 
----------------------------------------------------------------------------

> > Please let me test more patches. I will keep up with you.

I hope it will be your help.

> Or you could try the 2.4 version, as I said originally the 2.2 patch
> hasn't been tested at all. It would be nice to know if that works
> for you, as I may have screwed up the backport a bit.

Before goto bed, I will get 2.4.x kernel and add your patch.
I will report again.

Best Regards,

-- 
 WWWWW  shibata@luky.org
 |O-O|  Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233    IRC: #luky
   ~    http://his.luky.org/ last update:2000.3.12
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Jens Axboe]

On Tue, Oct 31 2000, Hisaaki Shibata wrote:
> By using serial console, I get messages for you ;-)

Thanks, now you're just one step short of being really
helpful :-). Pass it through ksymoops please, so the
addresses will map to function names + offsets.

> In case of doing "dd if=/dev/zero of=/dev/hdc bs=2048 count=1".
> ----------------------------------------------------------------------------
> hdc: ATAPI DVD-ROM DVD-RAM drive, 512kB Cache, UDMA(33)
> hdc: timeout waiting for DMA
> ide_dmaproc: chipset supported ide_dma_timeout func only: 14

Try it without DMA as well, please. I think I see a DMA bug in there right
now, I'll recheck and send you a new patch.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Hisaaki Shibata]

[-- Attachment #1: Type: Text/Plain, Size: 686 bytes --]

Hi,

> > By using serial console, I get messages for you ;-)
> 
> Thanks, now you're just one step short of being really
> helpful :-). Pass it through ksymoops please, so the
> addresses will map to function names + offsets.

I atacched files. Is it OK?

> > hdc: timeout waiting for DMA
> > ide_dmaproc: chipset supported ide_dma_timeout func only: 14
> 
> Try it without DMA as well, please. I think I see a DMA bug in there right
> now, I'll recheck and send you a new patch.

I see. I will try it and will report it.

Best Regards,

-- 
 WWWWW  shibata@luky.org
 |O-O|  Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233    IRC: #luky
   ~    http://his.luky.org/ last update:2000.3.12

[-- Attachment #2: trace2.txt --]
[-- Type: Text/Plain, Size: 4580 bytes --]

ksymoops 2.3.4 on i686 2.2.17-RAID-reiser-ide.all-ide-cd.  Options used
     -V (default)
     -k /proc/ksyms (default)
     -l /proc/modules (default)
     -o /lib/modules/2.2.17-RAID-reiser-ide.all-ide-cd/ (default)
     -m /usr/src/linux/System.map (default)

Warning: You did not tell me where to find symbol information.  I will
assume that the log matches the kernel and modules that are running
right now and I'll use the default options above for symbol resolution.
If the current kernel and/or modules do not match the log, you can get
more accurate output by telling me the kernel version and where to find
map, modules, ksyms etc.  ksymoops -h explains the options.

Warning (compare_maps): ksyms_base symbol module_list_R__ver_module_list not found in System.map.  Ignoring ksyms_base entry
Unable to handle kernel NULL pointer dereference at virtual address 0000002c
current->tss.cr3 = 13185000, %cr3 = 13185000
*pde = 00000000
Oops: 0000
CPU:    1
EIP:    0010:[<c01a7b0a>]
Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010292
eax: 00000000   ebx: 0000f008   ecx: 128e395c   edx: c02402d8
esi: 00000001   edi: d7fda800   ebp: c0240318   esp: d3013bec
ds: 0018   es: 0018   ss: 0018
Process fdisk (pid: 704, process nr: 60, stackpage=d3013000)
Stack: c02402d8 c0240318 00000002 00000087 c017d6bc c01c5d49 000001c2 00000000
       c016afd4 c01a7fde c0240318 00000001 00000001 c019a771 c0240318 d5960e00
       00008000 00000001 c0240318 d5960e00 00000000 00000001 c02296f8 00000286
Call Trace: [<c017d6bc>] [<c01c5d49>] [<c016afd4>] [<c01a7fde>] [<c019a771>] [<c01a9f82>] [<d8aaf81c>]
       [<d8aaf85a>] [<c019961a>] [<c01c5d49>] [<d8ab0832>] [<d8ab0788>] [<c012c44f>] [<d8ab094d>] [<c019aa66>]
       [<c012c44f>] [<c019adc6>] [<c01989cf>] [<c019ae8b>] [<c0197bb0>] [<d880164c>] [<c012b631>] [<d880164c>]
       [<c0164430>] [<d8800000>] [<d8801674>] [<d8801680>] [<c0167623>] [<d880164c>] [<d8820e3c>] [<c0166933>]
       [<c01d99cf>] [<c0159d77>] [<c012e95c>] [<c012b8f7>] [<c012b8ee>] [<c01b8aa4>] [<c012b94d>] [<c010a47d>]
       [<c010a344>]
Code: 8b 58 2c c7 44 24 1c 00 00 00 00 85 db 75 13 8b 70 20 8b 48 

>>EIP; c01a7b0a <ide_build_dmatable+1a/114>   <=====
Trace; c017d6bc <tcp_write_space+1c/60>
Trace; c01c5d49 <__const_udelay+29/30>
Trace; c016afd4 <kfree_skbmem+3c/4c>
Trace; c01a7fde <ide_dmaproc+e2/20c>
Trace; c019a771 <ide_wait_stat+85/e8>
Trace; c01a9f82 <piix_dmaproc+2e/38>
Trace; d8aaf81c <END_OF_CODE+e1f9/????>
Trace; d8aaf85a <END_OF_CODE+e237/????>
Trace; c019961a <ide_end_request+4e/94>
Trace; c01c5d49 <__const_udelay+29/30>
Trace; d8ab0832 <END_OF_CODE+f20f/????>
Trace; d8ab0788 <END_OF_CODE+f165/????>
Trace; c012c44f <refile_buffer+57/bc>
Trace; d8ab094d <END_OF_CODE+f32a/????>
Trace; c019aa66 <start_request+17e/1ec>
Trace; c012c44f <refile_buffer+57/bc>
Trace; c019adc6 <ide_do_request+2ce/32c>
Trace; c01989cf <make_request+673/844>
Trace; c019ae8b <do_ide1_request+13/1c>
Trace; c0197bb0 <unplug_device+48/58>
Trace; d880164c <_end+185bece4/186b9698>
Trace; c012b631 <__wait_on_buffer+c1/134>
Trace; d880164c <_end+185bece4/186b9698>
Trace; c0164430 <flush_commit_list+2dc/44c>
Trace; d8800000 <_end+185bd698/186b9698>
Trace; d8801674 <_end+185bed0c/186b9698>
Trace; d8801680 <_end+185bed18/186b9698>
Trace; c0167623 <do_journal_end+767/9d0>
Trace; d880164c <_end+185bece4/186b9698>
Trace; d8820e3c <_end+185de4d4/186b9698>
Trace; c0166933 <flush_old_commits+1d3/1e4>
Trace; c01d99cf <cprt+6f4f/8640>
Trace; c0159d77 <reiserfs_write_super+1b/28>
Trace; c012e95c <sync_supers+70/84>
Trace; c012b8f7 <fsync_dev+1f/4c>
Trace; c012b8ee <fsync_dev+16/4c>
Trace; c01b8aa4 <write_chan+0/24c>
Trace; c012b94d <sys_sync+29/44>
Trace; c010a47d <error_code+2d/40>
Trace; c010a344 <system_call+34/40>
Code;  c01a7b0a <ide_build_dmatable+1a/114>
00000000 <_EIP>:
Code;  c01a7b0a <ide_build_dmatable+1a/114>   <=====
   0:   8b 58 2c                  mov    0x2c(%eax),%ebx   <=====
Code;  c01a7b0d <ide_build_dmatable+1d/114>
   3:   c7 44 24 1c 00 00 00      movl   $0x0,0x1c(%esp,1)
Code;  c01a7b14 <ide_build_dmatable+24/114>
   a:   00 
Code;  c01a7b15 <ide_build_dmatable+25/114>
   b:   85 db                     test   %ebx,%ebx
Code;  c01a7b17 <ide_build_dmatable+27/114>
   d:   75 13                     jne    22 <_EIP+0x22> c01a7b2c <ide_build_dmatable+3c/114>
Code;  c01a7b19 <ide_build_dmatable+29/114>
   f:   8b 70 20                  mov    0x20(%eax),%esi
Code;  c01a7b1c <ide_build_dmatable+2c/114>
  12:   8b 48 00                  mov    0x0(%eax),%ecx


2 warnings issued.  Results may not be reliable.

[-- Attachment #3: trace1.txt --]
[-- Type: Text/Plain, Size: 3939 bytes --]

ksymoops 2.3.4 on i686 2.2.17-RAID-reiser-ide.all-ide-cd.  Options used
     -V (default)
     -k /proc/ksyms (default)
     -l /proc/modules (default)
     -o /lib/modules/2.2.17-RAID-reiser-ide.all-ide-cd/ (default)
     -m /usr/src/linux/System.map (default)

Warning: You did not tell me where to find symbol information.  I will
assume that the log matches the kernel and modules that are running
right now and I'll use the default options above for symbol resolution.
If the current kernel and/or modules do not match the log, you can get
more accurate output by telling me the kernel version and where to find
map, modules, ksyms etc.  ksymoops -h explains the options.

Warning (compare_maps): ksyms_base symbol module_list_R__ver_module_list not found in System.map.  Ignoring ksyms_base entry
Unable to handle kernel NULL pointer dereference at virtual address 00000014
current->tss.cr3 = 00101000, %cr3 = 00101000
*pde = 00000000
Oops: 0000
CPU:    0
EIP:    0010:[<d8ab07a1>]
Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010292
eax: 00000000   ebx: c0240318   ecx: 00000003   edx: d8ab0788
esi: d58a2600   edi: 00000080   ebp: 00000001   esp: c020dd74
ds: 0018   es: 0018   ss: 0018
Process swapper (pid: 0, process nr: 0, stackpage=c020d000)
Stack: 00000080 00000001 c0240318 d58a2600 00008000 00000001 c0229c20 00000286
       00feaac0 0080a3a4 c022d900 d2f157a0 c0229c20 d8aaf81c c020dde8 c0240318
       00000000 d8aaf917 c0240318 00000000 00000188 c019961a 00000000 d58a2600
Call Trace: [<d8aaf81c>] [<d8aaf917>] [<c019961a>] [<c01c5d49>] [<d8ab0832>] [<d8ab0788>] [<d8ab094d>]
       [<c019aa66>] [<c019adc0>] [<c019adc6>] [<c019b19e>] [<c019af74>] [<c011123b>] [<c0115775>] [<c0111994>]
       [<c0111946>] [<c011c99d>] [<c0106000>] [<c010ca89>] [<c010caa0>] [<c010b4f8>] [<c0106000>] [<c0108a11>]
       [<c0106000>] [<c010607c>] [<c0106000>] [<c01001ae>]
Code: 8b 50 14 8b 70 10 8d 44 24 34 89 44 24 18 c1 ee 02 31 c0 8b

>>EIP; d8ab07a1 <END_OF_CODE+f17e/????>   <=====
Trace; d8aaf81c <END_OF_CODE+e1f9/????>
Trace; d8aaf917 <END_OF_CODE+e2f4/????>
Trace; c019961a <ide_end_request+4e/94>
Trace; c01c5d49 <__const_udelay+29/30>
Trace; d8ab0832 <END_OF_CODE+f20f/????>
Trace; d8ab0788 <END_OF_CODE+f165/????>
Trace; d8ab094d <END_OF_CODE+f32a/????>
Trace; c019aa66 <start_request+17e/1ec>
Trace; c019adc0 <ide_do_request+2c8/32c>
Trace; c019adc6 <ide_do_request+2ce/32c>
Trace; c019b19e <ide_timer_expiry+22a/244>
Trace; c019af74 <ide_timer_expiry+0/244>
Trace; c011123b <smp_local_timer_interrupt+d3/148>
Trace; c0115775 <timer_bh+2d1/404>
Trace; c0111994 <do_edge_ioapic_IRQ+78/a8>
Trace; c0111946 <do_edge_ioapic_IRQ+2a/a8>
Trace; c011c99d <do_bottom_half+89/ac>
Trace; c0106000 <get_options+0/7c>
Trace; c010ca89 <do_IRQ+3d/58>
Trace; c010caa0 <do_IRQ+54/58>
Trace; c010b4f8 <common_interrupt+18/20>
Trace; c0106000 <get_options+0/7c>
Trace; c0108a11 <cpu_idle+41/54>
Trace; c0106000 <get_options+0/7c>
Trace; c010607c <init+0/144>
Trace; c0106000 <get_options+0/7c>
Trace; c01001ae <L6+0/2>
Code;  d8ab07a1 <END_OF_CODE+f17e/????>
00000000 <_EIP>:
Code;  d8ab07a1 <END_OF_CODE+f17e/????>   <=====
   0:   8b 50 14                  mov    0x14(%eax),%edx   <=====
Code;  d8ab07a4 <END_OF_CODE+f181/????>
   3:   8b 70 10                  mov    0x10(%eax),%esi
Code;  d8ab07a7 <END_OF_CODE+f184/????>
   6:   8d 44 24 34               lea    0x34(%esp,1),%eax
Code;  d8ab07ab <END_OF_CODE+f188/????>
   a:   89 44 24 18               mov    %eax,0x18(%esp,1)
Code;  d8ab07af <END_OF_CODE+f18c/????>
   e:   c1 ee 02                  shr    $0x2,%esi
Code;  d8ab07b2 <END_OF_CODE+f18f/????>
  11:   31 c0                     xor    %eax,%eax
Code;  d8ab07b4 <END_OF_CODE+f191/????>
  13:   8b 00                     mov    (%eax),%eax

Aiee, killing interrupt handler
Kernel panic: Attempted to kill the idle task!
In swapper task - not syncing   

2 warnings issued.  Results may not be reliable.

Re: patch: atapi dvd-ram support

[Hisaaki Shibata]

> Or you could try the 2.4 version, as I said originally the 2.2 patch
> hasn't been tested at all. It would be nice to know if that works
> for you, as I may have screwed up the backport a bit.

I tested on 2.4-test10 + dvd-ram-240t10p5.diff.bz2 + dvdram-ro_fix.diff env.
It occured oops too :-(.

And I forgot to say that my DVD-RAM drive is a new 9.4GB DVD-RAM model drive.

Best Regards,

Hisaaki Shibata

-- 
 WWWWW  shibata@luky.org
 |O-O|  Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233    IRC: #luky
   ~    http://his.luky.org/ last update:2000.3.12
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: patch: atapi dvd-ram support

[Jens Axboe]

On Sat, Nov 11 2000, Hisaaki Shibata wrote:
> > Or you could try the 2.4 version, as I said originally the 2.2 patch
> > hasn't been tested at all. It would be nice to know if that works
> > for you, as I may have screwed up the backport a bit.
> 
> I tested on 2.4-test10 + dvd-ram-240t10p5.diff.bz2 + dvdram-ro_fix.diff env.
> It occured oops too :-(.

Interesting, then it isn't the backport that is buggy.

> And I forgot to say that my DVD-RAM drive is a new 9.4GB DVD-RAM model drive.

I'd like to know specifically what make/model drive you have? The
oops you sent earlier seems to indicate an empty ide dma request setup.
If you disable DMA on the drive, does it then work? I'd send you a
patch right now, but I have to unpack my trees first.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/