Re: [PATCH] kiobuf/rawio fixes for 2.4.0-test10-pre6

["Stephen C. Tweedie" <sct@redhat.com>]

Hi,

On Mon, Oct 30, 2000 at 01:56:07PM -0500, Jeff Garzik wrote:
> 
> Seen it, re-read my question...
> 
> I keep seeing "audio drivers' mmap" used a specific example of a place
> that would benefit from kiobufs.  The current via audio mmap looks quite
> a bit like mmap_kiobuf and its support code... except without all the
> kiobuf overhead.
> 
> My question from above is:  how can the via audio mmap in test10-preXX
> be improved by using kiobufs?  I am not a kiobuf expert, but AFAICS a
> non-kiobuf implementation is better for audio drivers. 

Code reuse.  You may not need every single thing that the kvmap api
gives you --- for example, you may not need the per-mmap refcounting,
because you might be associating your dma buffer with the file
descriptor, not the mmap region --- but if you implement the same
nopage code in every single sound driver, then you end up with a lot
of duplication and you increase (enormously) the number of places you
have to touch if anything ever changes in the vma management code.

Cheers,
 Stephen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/