public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Malcolm Beattie <mbeattie@sable.ox.ac.uk>
To: Keith Owens <kaos@ocs.com.au>
Cc: Peter Samuelson <peter@cadcamlab.org>,
	Torsten.Duwe@caldera.de, Chris Evans <chris@scary.beasts.org>,
	linux-kernel@vger.kernel.org
Subject: Re: Modprobe local root exploit
Date: Tue, 14 Nov 2000 10:42:41 +0000	[thread overview]
Message-ID: <20001114104240.A30388@sable.ox.ac.uk> (raw)
In-Reply-To: <20001113230210.F18203@wire.cadcamlab.org> <3864.974181019@kao2.melbourne.sgi.com>
In-Reply-To: <3864.974181019@kao2.melbourne.sgi.com>; from kaos@ocs.com.au on Tue, Nov 14, 2000 at 04:50:19PM +1100

Keith Owens writes:
> All these patches against request_module are attacking the problem at
> the wrong point.  The kernel can request any module name it likes,
> using any string it likes, as long as the kernel generates the name.
> The real problem is when the kernel blindly accepts some user input and
> passes it straight to modprobe, then the kernel is acting like a setuid
> wrapper for a program that was never designed to run setuid.

Rather than add sanity checking to modprobe, it would be a lot easier
and safer from a security audit point of view to have the kernel call
/sbin/kmodprobe instead of /sbin/modprobe. Then kmodprobe can sanitise
all the data and exec the real modprobe. That way the only thing that
needs auditing is a string munging/sanitising program.

--Malcolm

-- 
Malcolm Beattie <mbeattie@sable.ox.ac.uk>
Unix Systems Programmer
Oxford University Computing Services
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  parent reply	other threads:[~2000-11-14 11:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-13 14:37 Modprobe local root exploit Gregory Maxwell
2000-11-13 16:26 ` Torsten Duwe
2000-11-13 16:44   ` Francis Galiegue
2000-11-13 16:45     ` Torsten Duwe
2000-11-13 16:56       ` Chris Evans
2000-11-13 17:21         ` Jan Dvorak
2000-11-13 18:11         ` Torsten Duwe
2000-11-14  5:02           ` Peter Samuelson
2000-11-14  5:50             ` Keith Owens
2000-11-14  9:19               ` Florian Weimer
2000-11-14 10:42               ` Malcolm Beattie [this message]
2000-11-14 10:54                 ` Jakub Jelinek
2000-11-14 11:58                   ` Chris Evans
2000-11-14 10:58                 ` Keith Owens
2000-11-14 12:28           ` Nick Holloway
2000-11-14 14:01           ` David Woodhouse
2000-11-14  1:35         ` Horst von Brand
2000-11-13 19:46       ` Peter Samuelson
2000-11-14 11:29         ` Daniel Phillips
2000-11-14 14:23           ` Daniel Phillips
2000-11-14 16:25           ` David Relson
2000-11-15  4:09           ` Horst von Brand
2000-11-16  5:22       ` Alan Cox
2000-11-16  6:04         ` H. Peter Anvin
2000-11-16  6:14           ` Keith Owens
2000-11-16  6:16             ` H. Peter Anvin
2000-11-16 14:12         ` Torsten Duwe
2000-11-16 15:07           ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20001114104240.A30388@sable.ox.ac.uk \
    --to=mbeattie@sable.ox.ac.uk \
    --cc=Torsten.Duwe@caldera.de \
    --cc=chris@scary.beasts.org \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@cadcamlab.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox