From: Johannes Erdfelt <jerdfelt@valinux.com>
To: Oleg Drokin <green@ixcelerator.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: hardcoded HZ in hub.c
Date: Mon, 20 Nov 2000 12:17:46 -0800 [thread overview]
Message-ID: <20001120121746.F895@valinux.com> (raw)
In-Reply-To: <20001117125441.A28208@iXcelerator.com>
In-Reply-To: <20001117125441.A28208@iXcelerator.com>; from green@ixcelerator.com on Fri, Nov 17, 2000 at 12:54:41PM +0300
On Fri, Nov 17, 2000, Oleg Drokin <green@ixcelerator.com> wrote:
> hub.c in 2.4.0-test10 and above contains hardcoded HZ value,
> which is wrong. Here is the patch:
>
>
> --- drivers/usb/hub.c.orig Fri Nov 17 12:51:34 2000
> +++ drivers/usb/hub.c Fri Nov 17 12:51:59 2000
> @@ -813,7 +813,7 @@
> ret = kill_proc(khubd_pid, SIGTERM, 1);
> if (!ret) {
> /* Wait 10 seconds */
> - int count = 10 * 100;
> + int count = 10 * HZ;
>
> while (khubd_running && --count) {
> current->state = TASK_INTERRUPTIBLE;
We applied a slightly different patch which is would not remove the pages
out from under the thread, using semaphores instead.
This patch isn't needed anymore. Thanks anyway.
JE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-20 20:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-17 9:54 hardcoded HZ in hub.c Oleg Drokin
2000-11-20 20:17 ` Johannes Erdfelt [this message]
2000-11-21 10:13 ` David Woodhouse
2000-11-21 17:56 ` Johannes Erdfelt
2000-11-21 19:13 ` David Woodhouse
2000-11-21 19:26 ` Johannes Erdfelt
2000-11-22 10:48 ` David Woodhouse
2000-11-22 11:22 ` Andrew Morton
2000-11-22 11:26 ` David Woodhouse
2000-11-22 11:34 ` Andrew Morton
2000-11-22 11:47 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001120121746.F895@valinux.com \
--to=jerdfelt@valinux.com \
--cc=green@ixcelerator.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox