From: Andrea Arcangeli <andrea@suse.de>
To: "H . J . Lu" <hjl@valinux.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: lseek patch for 2.2.18pre23
Date: Fri, 24 Nov 2000 15:21:53 +0100 [thread overview]
Message-ID: <20001124152153.A23297@athlon.random> (raw)
In-Reply-To: <20001123221524.A32154@valinux.com>
In-Reply-To: <20001123221524.A32154@valinux.com>; from hjl@valinux.com on Thu, Nov 23, 2000 at 10:15:24PM -0800
On Thu, Nov 23, 2000 at 10:15:24PM -0800, H . J . Lu wrote:
> 2.2.18pre23 allows lseek to negative offsets in ext2 and has no checks
> for proc. Here is a patch.
As just said your patch is wrong for vanilla 2.2.18pre23.
The right fix for that problem in 2.2.18pre23 (2.2.x vanilla doesn't include
LFS) is here:
ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.2/2.2.18pre22/lseek-2g-ext2-1
I also uploaded separately your right fix for /dev/mem:
ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.2/2.2.18pre22/lseek-2g-mem-hjl-1 (this one is
and this the right fix for the largefile handling in ext2:
ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.2/2.2.18pre22/notify-change-2g-ext2-1
All three should be applied to 2.2.18pre-latest.
And in LFS (that means also 2.4.x) the >> 32 doesn't make any sense in lseek
and should be removed:
ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.4/2.4.0-test11-pre6/ext2-lseek-cleanup-1
Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-24 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-24 6:15 lseek patch for 2.2.18pre23 H . J . Lu
2000-11-24 14:21 ` Andrea Arcangeli [this message]
2000-11-24 15:00 ` kernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001124152153.A23297@athlon.random \
--to=andrea@suse.de \
--cc=hjl@valinux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox