From: Vojtech Pavlik <vojtech@suse.cz>
To: Rusty Russell <rusty@linuxcare.com.au>
Cc: Tigran Aivazian <tigran@veritas.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] removal of "static foo = 0" from drivers/ide (test11)
Date: Fri, 24 Nov 2000 22:40:18 +0100 [thread overview]
Message-ID: <20001124224018.A5173@suse.cz> (raw)
In-Reply-To: <Pine.LNX.4.21.0011212300590.950-100000@penguin.homenet> <20001123110203.EB8A8813D@halfway.linuxcare.com.au>
In-Reply-To: <20001123110203.EB8A8813D@halfway.linuxcare.com.au>; from rusty@linuxcare.com.au on Thu, Nov 23, 2000 at 10:01:53PM +1100
On Thu, Nov 23, 2000 at 10:01:53PM +1100, Rusty Russell wrote:
> In message <Pine.LNX.4.21.0011212300590.950-100000@penguin.homenet> you write:
> > > On Tue, 21 Nov 2000 22:25:01 Bartlomiej Zolnierkiewicz wrote:
> > > >
> > > > Quick removal of unnecessary initialization to 0.
> >
> > Quite the contrary. The patch seems correct and useful to me. What do you
> > think is wrong with it? (Linus accepted megabytes worth of the above in
> > the past...)
>
> What irritates about these monkey-see-monkey-do patches is that if I
> initialize a variable to NULL, it's because my code actually relies on
> it; I don't want that information eliminated.
Yes, but if it generates a bigger (== worse) binary?
--
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-24 22:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-21 21:25 [PATCH] removal of "static foo = 0" from drivers/ide (test11) Bartlomiej Zolnierkiewicz
2000-11-21 22:55 ` J . A . Magallon
2000-11-21 23:04 ` Tigran Aivazian
2000-11-21 23:18 ` J . A . Magallon
2000-11-21 23:26 ` Tigran Aivazian
2000-11-21 23:30 ` J . A . Magallon
2000-11-23 11:01 ` Rusty Russell
2000-11-24 21:40 ` Vojtech Pavlik [this message]
[not found] ` <20001128031933.52DB981F5@halfway.linuxcare.com.au>
2000-11-28 8:59 ` Vojtech Pavlik
2000-11-24 23:13 ` J . A . Magallon
2000-11-25 12:01 ` Russell King
2000-11-25 11:50 ` Russell King
2000-11-25 23:56 ` Bartlomiej Zolnierkiewicz
2000-11-22 0:09 ` Jeff Garzik
2000-11-22 11:40 ` Russell King
-- strict thread matches above, loose matches on Subject: below --
2000-11-28 20:58 David Hinds
2000-11-28 21:08 ` Tigran Aivazian
2000-11-28 23:53 ` Peter Samuelson
2000-11-29 3:23 ` Keith Owens
2000-11-29 3:35 ` Peter Samuelson
2000-11-29 7:48 ` Tigran Aivazian
2000-11-29 14:00 ` Peter Samuelson
2000-11-29 14:08 ` Tigran Aivazian
2000-11-29 16:16 Darryl Miles
2000-11-29 23:54 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001124224018.A5173@suse.cz \
--to=vojtech@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@linuxcare.com.au \
--cc=tigran@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox