Re: [PATCH] removal of "static foo = 0" from drivers/ide (test11)

Tigran Aivazian
2000-11-21T23:35:07Z

On Tue, 21 Nov 2000, J . A . Magallon wrote:

>
> On Tue, 21 Nov 2000 22:25:01 Bartlomiej Zolnierkiewicz wrote:
> >
> > Quick removal of unnecessary initialization to 0.
> >
> >
> > -static int basePort = 0; /* base port address */
> > -static int regPort = 0; /* port for register number */
> > -static int dataPort = 0; /* port for register data */
> > +static int basePort; /* base port address */
> > +static int regPort; /* port for register number */
> > +static int dataPort; /* port for register data */
>
> That is not too much confidence on the ANSI-ness of the compiler ???
>

Quite the contrary. The patch seems correct and useful to me. What do you
think is wrong with it? (Linus accepted megabytes worth of the above in
the past...)

(see arch/i386/kernel/head.S and look for surprised. This is becoming FAQ,
Richard, how about putting it into your FAQ mentioned at the bottom of
this message?)

Regards,
Tigran