From: Pavel Machek <pavel@suse.cz>
To: Thomas Sailer <sailer@ife.ee.ethz.ch>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: 2.4.0-testx: USB Audio
Date: Tue, 28 Nov 2000 00:04:56 +0100 [thread overview]
Message-ID: <20001128000456.A2732@bug.ucw.cz> (raw)
In-Reply-To: <200011271735.eARHZGZ05973@eldrich.ee.ethz.ch>
In-Reply-To: <200011271735.eARHZGZ05973@eldrich.ee.ethz.ch>; from Thomas Sailer on Mon, Nov 27, 2000 at 06:35:16PM +0100
HI!
> This patch adds a workaround for the Dallas chip; the chip tags
> its 8bit formats with PCM8 but expects signed data.
> @@ -2895,6 +2897,9 @@
> continue;
> }
> format = (fmt[5] == 2) ? (AFMT_U16_LE | AFMT_U8) : (AFMT_S16_LE | AFMT_S8);
> + /* Dallas DS4201 workaround */
> + if (dev->descriptor.idVendor == 0x04fa && dev->descriptor.idProduct == 0x4201)
> + format = (AFMT_S16_LE | AFMT_S8);
Should not you printk() in case of buggy hardware?
Pavel
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-11-28 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-27 17:35 [PATCH]: 2.4.0-testx: USB Audio Thomas Sailer
2000-11-27 18:16 ` Johannes Erdfelt
2000-11-27 23:04 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001128000456.A2732@bug.ucw.cz \
--to=pavel@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=sailer@ife.ee.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox