From: Jens Axboe <axboe@suse.de>
To: schwidefsky@de.ibm.com
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@transmeta.com>
Subject: Re: plug problem in linux-2.4.0-test11
Date: Wed, 29 Nov 2000 15:23:08 +0100 [thread overview]
Message-ID: <20001129152308.A28399@suse.de> (raw)
In-Reply-To: <C12569A6.00425037.00@d12mta07.de.ibm.com>
In-Reply-To: <C12569A6.00425037.00@d12mta07.de.ibm.com>; from schwidefsky@de.ibm.com on Wed, Nov 29, 2000 at 12:56:44PM +0100
On Wed, Nov 29 2000, schwidefsky@de.ibm.com wrote:
> request queue to put them on its internal queue. You could argue
> that it shouldn't dequeue request if q->plugged == 1. On the other
> hand why not, before the disk has nothing to do. Anyway the result
I agree with your reasoning, even if the s390 behaviour is a bit
"non-standard" wrt block devices. Linus, could you apply?
--- drivers/block/ll_rw_blk.c~ Wed Nov 29 15:17:33 2000
+++ drivers/block/ll_rw_blk.c Wed Nov 29 15:18:43 2000
@@ -347,10 +347,9 @@
*/
static inline void __generic_unplug_device(request_queue_t *q)
{
- if (!list_empty(&q->queue_head)) {
- q->plugged = 0;
+ q->plugged = 0;
+ if (!list_empty(&q->queue_head))
q->request_fn(q);
- }
}
static void generic_unplug_device(void *data)
--
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-29 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-29 11:56 plug problem in linux-2.4.0-test11 schwidefsky
2000-11-29 14:23 ` Jens Axboe [this message]
2000-11-29 17:52 ` Linus Torvalds
2000-11-29 18:11 ` Jens Axboe
2000-12-27 20:04 ` Andrea Arcangeli
2000-12-28 13:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001129152308.A28399@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox