From: Greg KH <greg@wirex.com>
To: "Mohammad A. Haque" <mhaque@haque.net>, linux-kernel@vger.kernel.org
Subject: Re: Keyspan USB PDA adapter && test12pre3 hang
Date: Thu, 30 Nov 2000 00:17:01 -0800 [thread overview]
Message-ID: <20001130001700.P19398@kroah.com> (raw)
In-Reply-To: <20001129234420.A7196@wirex.com>; from greg@wirex.com on
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
Wed, Nov 29, 2000 at 11:44:20PM -0800
X-Operating-System: Linux 2.2.17-immunix (i686)
On Wed, Nov 29, 2000 at 11:44:20PM -0800, Greg KH wrote:
> If so, the following fix from Georg Acher should do the trick:
>
> -----
> Replace line 275 (insert_td())
> qh->hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM;
> by
> qh->hw.qh.element = virt_to_bus (new) ;
>
> -----
Here's the above in patch form to make it easier for people to apply.
greg k-h
--
greg@(kroah|wirex).com
[-- Attachment #2: usb-uhci-2.4.0-test12-pre3.diff --]
[-- Type: text/plain, Size: 531 bytes --]
diff -Naur -X dontdiff linux-2.4.0-test12-pre3/drivers/usb/usb-uhci.c linux-2.4.0-test12-pre3-greg/drivers/usb/usb-uhci.c
--- linux-2.4.0-test12-pre3/drivers/usb/usb-uhci.c Wed Nov 29 23:37:19 2000
+++ linux-2.4.0-test12-pre3-greg/drivers/usb/usb-uhci.c Thu Nov 30 00:17:29 2000
@@ -272,7 +272,7 @@
if (qh == prev ) {
// virgin qh without any tds
- qh->hw.qh.element = virt_to_bus (new) | UHCI_PTR_TERM;
+ qh->hw.qh.element = virt_to_bus (new);
}
else {
// already tds inserted, implicitely remove TERM bit of prev
next prev parent reply other threads:[~2000-11-30 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-30 5:53 Keyspan USB PDA adapter && test12pre3 hang Mohammad A. Haque
2000-11-30 7:44 ` Greg KH
2000-11-30 8:17 ` Greg KH [this message]
2000-11-30 8:46 ` Mohammad A. Haque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001130001700.P19398@kroah.com \
--to=greg@wirex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhaque@haque.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox