From: Andreas Dilger <adilger@turbolinux.com>
To: Meelis Roos <mroos@linux.ee>
Cc: jbj_ss@mail.tele.dk, linux-kernel@vger.kernel.org
Subject: Re: Pls add this driver to the kernel tree !!
Date: Thu, 30 Nov 2000 11:03:25 -0700 (MST) [thread overview]
Message-ID: <200011301803.eAUI3Pu16137@webber.adilger.net> (raw)
In-Reply-To: <E141XZl-0005z9-00@roos.tartu-labor> "from Meelis Roos at Nov 30, 2000 07:32:53 pm"
Meelis Roos writes:
> JBJ> #ifdef INLINE_PCISCAN
> JBJ> #include "k_compat.h"
> JBJ> #else
> JBJ> #include "pci-scan.h"
> JBJ> #include "kern_compat.h"
> JBJ> #endif
>
> I quess you need to convert it to kernel PCI API first and probably also to
> optimize away the LINUX_VERSION_CODE checks (we know it's 2.4).
Actually, there is some benefit in leaving the LINUX_VERSION_CODE checks
there... If someone wants to back-port the driver to 2.2, this makes it
much easier. Also, some people like to maintain a single driver for all
of the kernel versions, so they don't have to bugfix each driver version.
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-30 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-28 2:51 Pls add this driver to the kernel tree !! John B. Jacobsen
2000-11-30 17:19 ` Tigran Aivazian
2000-11-30 17:32 ` Meelis Roos
2000-11-30 18:03 ` Andreas Dilger [this message]
2000-11-30 19:16 ` Mark Hahn
2000-11-30 20:41 ` Alan Cox
2000-11-30 20:06 ` Timur Tabi
2000-12-01 9:26 ` David Woodhouse
2000-12-01 19:43 ` David Schleef
2000-12-01 17:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200011301803.eAUI3Pu16137@webber.adilger.net \
--to=adilger@turbolinux.com \
--cc=jbj_ss@mail.tele.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox