public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.2.18pre24
Date: Thu, 30 Nov 2000 20:35:11 +0100	[thread overview]
Message-ID: <20001130203511.A18804@athlon.random> (raw)
In-Reply-To: <E140wh7-0005Na-00@the-village.bc.nu> <20001129150159.Y872@opus.bloom.county> <20001130181740.A18566@athlon.random> <20001130112643.A16256@opus.bloom.county>
In-Reply-To: <20001130112643.A16256@opus.bloom.county>; from trini@kernel.crashing.org on Thu, Nov 30, 2000 at 11:26:43AM -0700

On Thu, Nov 30, 2000 at 11:26:43AM -0700, Tom Rini wrote:
> Right.  But the problem here was a new, unused sysctl-by-number, conflicted
> with an old-but-not-integrated sysctl-by-number that is used. :)  The only

Who is using it? Not even the raid developers cared to take the
sysctl-by-number consistent between 2.4.0-test12-pre2 and 2.2.x raid 0.90
so nobody should be using it in first place.

Furthmore since the number 4 is the official one for raid/md, DEV_MAC_HID=3
isn't really colliding with the raid sysctl, but DEV_MAC_HID=3 is still wrong
because is it should be =5 to be consistent with 2.4.x...

2.2.x RAID 0.90:

 enum {
 	DEV_CDROM=1,
-	DEV_HWMON=2
+	DEV_HWMON=2,
+	DEV_MD=3
 };
[..]
+/* /proc/sys/dev/md */
+enum {
+	DEV_MD_SPEED_LIMIT=1
 };


2.2.18pre24:

enum {
	DEV_CDROM=1,
	DEV_HWMON=2,
	DEV_MAC_HID=3
};

2.4.0-test12-pre2:

enum {
	DEV_CDROM=1,
	DEV_HWMON=2,
	DEV_PARPORT=3,
	DEV_RAID=4,
	DEV_MAC_HID=5
};
[..]
/* /proc/sys/dev/raid */
enum {
	DEV_RAID_SPEED_LIMIT_MIN=1,
	DEV_RAID_SPEED_LIMIT_MAX=2
};

As we can clearly see nobody cares about the sysctl-by-number interface because
it generates collisions too easily so it should be declared obsolete and nobody
should use it anymore. sysctl-by-name is less performant but it doesn't
generate binary-level collisions so easily and in turn it's a big win for open
source projects where everybody has some tons of unofficial patches applied
(raid 0.90 in this case).

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      reply	other threads:[~2000-11-30 20:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-29  2:09 Linux 2.2.18pre24 Alan Cox
2000-11-29 22:01 ` Tom Rini
2000-11-30 17:17   ` Andrea Arcangeli
2000-11-30 18:26     ` Tom Rini
2000-11-30 19:35       ` Andrea Arcangeli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20001130203511.A18804@athlon.random \
    --to=andrea@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox