Re: mm->context[NR_CPUS] and pci fix check [was Re: Alpha SCSI error on 2.4.0-test11]

[Andrea Arcangeli <andrea@suse.de>]

On Fri, Dec 01, 2000 at 10:19:44AM -0800, David S. Miller wrote:
>    I'm still left the #ifdef __alpha__ around the context[NR_CPUS] to
>    avoid breakage of other archs but that should be probably removed:
>    any CPU with per-CPU ASNs like alpha needs per-CPU per-MM context
>    information to avoid wasting ASNs when the task migrate CPU or with
>    threads.
> 
> I would instead suggest to declare 'context' to be of an arch-specific
> defined type, much like "thread_struct" is.

I agree, really that should been the case since the first place because the 4
bytes of context are just a waste for x86* :). I mainly wanted to make sure
other archs was doing the right thing too.

> For example, I don't need NR_CPUS contexts in the mm_struct on
> sparc64, my allocation just works differently, so I shouldn't eat
> all the space.

I think at least mips wants to use per-mm per-cpu context too btw.

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/