From: Pavel Machek <pavel@suse.cz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Tjeerd Mulder <tjeerd.mulder@fujitsu-siemens.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i810_audio 2.4.0-test11
Date: Sun, 3 Dec 2000 22:23:00 +0100 [thread overview]
Message-ID: <20001203222300.B165@bug.ucw.cz> (raw)
In-Reply-To: <3A278916.6FF0C5DE@fujitsu-siemens.com> <E141ppq-0000DP-00@the-village.bc.nu>
In-Reply-To: <E141ppq-0000DP-00@the-village.bc.nu>; from Alan Cox on Fri, Dec 01, 2000 at 01:02:39PM +0000
Hi!
> > It implements mono output and fixes a bug in the dma logic (reset necessary
> > because some descriptors are already prefetched and are not updated
>
> This is wrong. Linus please do not apply this patch, or if you have done back
> it out. Not only does it do format conversions in kernel (which is a strict
> not to be done in the sound driver policy) it also makes it impossible to make
> mmap work correctly with the OSS API definitions.
>
> Tjeerd. I deliberately applied only small bits of your patch before because
> the mono mode stuff clutters the driver horribly and is not in the right place.
> It belongs in the application/libraries
Then you should kill parts of drivers/usb/audio - it contains format conversions.
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-04 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-01 11:18 [PATCH] i810_audio 2.4.0-test11 Tjeerd Mulder
2000-12-01 13:02 ` Alan Cox
2000-12-03 21:23 ` Pavel Machek [this message]
2000-12-04 11:37 ` Alan Cox
2000-12-04 13:45 ` Thomas Sailer
2000-12-04 16:37 ` Jeff Garzik
2000-12-04 18:15 ` Alan Cox
2000-12-04 18:23 ` Thomas Sailer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001203222300.B165@bug.ucw.cz \
--to=pavel@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tjeerd.mulder@fujitsu-siemens.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox