From: Pavel Machek <pavel@suse.cz>
To: Rasmus Andersen <rasmus@jaquet.dk>, perex@suse.cz
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove warning from drivers/net/hp100.c (240-test12-pre7)
Date: Sat, 9 Dec 2000 10:19:24 +0100 [thread overview]
Message-ID: <20001209101924.A126@bug.ucw.cz> (raw)
In-Reply-To: <20001208211908.D599@jaquet.dk>
In-Reply-To: <20001208211908.D599@jaquet.dk>; from Rasmus Andersen on Fri, Dec 08, 2000 at 09:19:08PM +0100
Hi!
> The following patch removes a 'defined but not used' warning from drivers/
> new/hp100.c when compiling without CONFIG_PCI (240t12p3). It should apply
> cleanly.
I'd say that warning is more acceptable than #ifdef... In cases where
warnings can be eliminating without ifdefs, that's okay, but this...
Pavel
> --- linux-240-t12-pre3-clean/drivers/net/hp100.c Sat Nov 4 23:27:07 2000
> +++ linux/drivers/net/hp100.c Sat Dec 2 16:07:27 2000
> @@ -265,12 +265,14 @@
>
> #define HP100_EISA_IDS_SIZE (sizeof(hp100_eisa_ids)/sizeof(struct hp100_eisa_id))
>
> +#ifdef CONFIG_PCI
> static struct hp100_pci_id hp100_pci_ids[] = {
> { PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_J2585A },
> { PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_J2585B },
> { PCI_VENDOR_ID_COMPEX, PCI_DEVICE_ID_COMPEX_ENET100VG4 },
> { PCI_VENDOR_ID_COMPEX2, PCI_DEVICE_ID_COMPEX2_100VG }
> };
> +#endif
>
> #define HP100_PCI_IDS_SIZE (sizeof(hp100_pci_ids)/sizeof(struct hp100_pci_id))
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-09 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-08 20:19 [PATCH] remove warning from drivers/net/hp100.c (240-test12-pre7) Rasmus Andersen
2000-12-09 9:19 ` Pavel Machek [this message]
2000-12-09 22:37 ` Peter Samuelson
2000-12-11 20:32 ` Rasmus Andersen
2000-12-12 0:09 ` Peter Samuelson
2000-12-12 13:49 ` Rasmus Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001209101924.A126@bug.ucw.cz \
--to=pavel@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox