Re: [2*PATCH] alpha I/O access and mb()

Richard Henderson
2000-12-11T00:50:51Z

On Sun, Dec 10, 2000 at 10:23:20PM +0100, Abramo Bagnara wrote:
> asm/io.h uses out of line function only when CONFIG_ALPHA_GENERIC is
> defined, otherwise it uses (take writel as an example) __raw_writel that
> IMHO need to be defined in core_t2.h.

Perhaps you should _show_ an actual failure rather than just guessing.

You are wildly incorrect asserting that out of line functions are used
only with CONFIG_ALPHA_GENERIC. You should examine

#ifndef __raw_writel
# define __raw_writel(v,a) ___raw_writel((v),(unsigned long)(a))
#endif

and suchlike definitions.

> core_t2.h is the only core_*.h file that does not define it and this is
> why I've proposed that patch.

FOR THE NTH TIME, NO IT IS NOT!

How often do I have to point you at the other files that do not
define (all of) these macros before you will believe me?

Jesus H Christ! Look at some preprocessor output why don't you?
Better yet, compile the kernel with CONFIG_ALPHA_T2. Notice how
it does not fail with undefined symbol errors. Notice how there
are non-trivial bit fiddling insns implementing the functions in
alpha/lib/io.o. That's the quickest way to see that I'm right
and you aren't.

End of discussion.

r~