From: Peter Samuelson <peter@cadcamlab.org>
To: Linus Torvalds <torvalds@transmeta.com>, Ralf Baechle <ralf@gnu.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: test12-pre8
Date: Sun, 10 Dec 2000 20:29:44 -0600 [thread overview]
Message-ID: <20001210202944.Y6567@cadcamlab.org> (raw)
In-Reply-To: <Pine.LNX.4.10.10012101014000.3153-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.10.10012101014000.3153-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Sun, Dec 10, 2000 at 10:18:00AM -0800
[Linus]
> - pre8:
Small thinko in arch/mips64/Makefile, looks like.
--- 2.4.0test12pre8/arch/mips64/Makefile~ Sun Dec 10 20:07:02 2000
+++ 2.4.0test12pre8/arch/mips64/Makefile Sun Dec 10 20:13:07 2000
@@ -33,7 +33,7 @@
# machines may also. Since BFD is incredibly buggy with respect to
# crossformat linking we rely on the elf2ecoff tool for format conversion.
#
-CFLAGS += -I $(TOPDIR)/include/asm $(CFLAGS)
+CFLAGS := -I $(TOPDIR)/include/asm $(CFLAGS)
CFLAGS += -mabi=64 -G 0 -mno-abicalls -fno-pic -Wa,--trap -pipe
LINKFLAGS += -G 0 -static # -N
MODFLAGS += -mlong-calls
But that brings up the question: why does mips64 need to specify the
'-I $(TOPDIR)/include/asm-mips64' at all? A quick grep through
arch/mips64 and include/asm-mips64 does not reveal any reason.
So AFAICS it should actually be
--- 2.4.0test12pre8/arch/mips64/Makefile~ Sun Dec 10 20:07:02 2000
+++ 2.4.0test12pre8/arch/mips64/Makefile Sun Dec 10 20:13:07 2000
@@ -33,7 +33,6 @@
# machines may also. Since BFD is incredibly buggy with respect to
# crossformat linking we rely on the elf2ecoff tool for format conversion.
#
-CFLAGS += -I $(TOPDIR)/include/asm $(CFLAGS)
CFLAGS += -mabi=64 -G 0 -mno-abicalls -fno-pic -Wa,--trap -pipe
LINKFLAGS += -G 0 -static # -N
MODFLAGS += -mlong-calls
Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-12-11 3:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-10 18:18 test12-pre8 Linus Torvalds
2000-12-10 18:31 ` test12-pre8 Linus Torvalds
2000-12-10 20:00 ` test12-pre8 Mohammad A. Haque
2000-12-10 22:23 ` test12-pre8 Urban Widmark
2000-12-10 22:49 ` test12-pre8 Mohammad A. Haque
2000-12-11 2:29 ` Peter Samuelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001210202944.Y6567@cadcamlab.org \
--to=peter@cadcamlab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@gnu.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox