[PATCH] ide-pci.c: typo

[PATCH] ide-pci.c: typo

[Frédéric L . W . Meunier]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

dmesg: VP_IDE: not 100% native mode: will probe irqs later
syslog: Dec 11 14:28:48 pervalidus kernel: VP_IDE: not 100%% native mode: will probe irqs later


-- 
0@pervalidus.{net,{dyndns.}org} TelFax: 55-21-717-2399 (Niterói-RJ BR)

[-- Attachment #2: ide-pci.c.diff --]
[-- Type: text/plain, Size: 514 bytes --]

--- linux/drivers/block/ide-pci.c.old	Sun Dec 10 23:10:22 2000
+++ linux/drivers/block/ide-pci.c	Mon Dec 11 20:16:36 2000
@@ -344,7 +344,7 @@
 	 */
 	pciirq = dev->irq;
 	if ((dev->class & ~(0xfa)) != ((PCI_CLASS_STORAGE_IDE << 8) | 5)) {
-		printk("%s: not 100%% native mode: will probe irqs later\n", d->name);
+		printk("%s: not 100% native mode: will probe irqs later\n", d->name);
 		pciirq = ide_special_settings(dev, d->name);
 	} else if (tried_config) {
 		printk("%s: will probe irqs later\n", d->name);

Re: [PATCH] ide-pci.c: typo

[Alan Cox]

>  	if ((dev->class & ~(0xfa)) != ((PCI_CLASS_STORAGE_IDE << 8) | 5)) {
> -		printk("%s: not 100%% native mode: will probe irqs later\n", d->name);
> +		printk("%s: not 100% native mode: will probe irqs later\n", d->name);
>  		pciirq = ide_special_settings(dev, d->name);

I disagree with the patch. The bug is in printk


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ide-pci.c: typo

[Frédéric L . W . Meunier]

Alan Cox wrote:

> I disagree with the patch. The bug is in printk

No problem. So, it's a bug report instead. I have no clues,
and just thought it'd be a fix :)

Not sure if 2.2.17 reported the double %% from syslog. I
usually look at my dmesg.

-- 
0@pervalidus.{net,{dyndns.}org} TelFax: 55-21-717-2399 (Niterói-RJ BR)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ide-pci.c: typo

[Bruce Korb]

Frédéric L . W . Meunier wrote:
> 
> Alan Cox wrote:
...

There are several typos, but it is not clear if they are all
from ide-pci.c, or in the other files (pci.ids and pci_ids.h).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ide-pci.c: typo

[Matthew Kirkwood]

On Mon, 11 Dec 2000, Frédéric L . W . Meunier wrote:

> > I disagree with the patch. The bug is in printk
>
> No problem. So, it's a bug report instead. I have no clues, and just
> thought it'd be a fix :)
>
> Not sure if 2.2.17 reported the double %% from syslog. I usually look
> at my dmesg.

If it matters, I have vague recollections that the double %%
was added to prevent klogd from segfaulting.  Since everyone
has fixed their klogd's because that bug was actually (probably)
an exploitable security hole, all should be well, right?

Matthew.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/