link failure (drivers/char/riscom8.c) (240test13p2)

link failure (drivers/char/riscom8.c) (240test13p2)

[Rasmus Andersen]

Hi.

In the link phase of a kernel 240t13p2 build I get the following:

drivers/char/char.o: In function `tty_init':
drivers/char/char.o(.text.init+0x259): undefined reference to `riscom8_init'

I guess this is bacause riscom8_init is now a static function and thus
tty_init cannot see it. If this is intentional or nat I cannot judge
but I guess the fix is either to remove the static or the initcall from
tty_init. The decision I leave with those who know what to do.

-- 
Regards,
        Rasmus(rasmus@jaquet.dk)

           My other .sig is a porsche
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: link failure (drivers/char/riscom8.c) (240test13p2)

[Alan Cox]

> drivers/char/char.o: In function `tty_init':
> drivers/char/char.o(.text.init+0x259): undefined reference to `riscom8_init'
> 
> I guess this is bacause riscom8_init is now a static function and thus
> tty_init cannot see it. If this is intentional or nat I cannot judge
> but I guess the fix is either to remove the static or the initcall from
> tty_init. The decision I leave with those who know what to do.

Remove the call from tty_init. riscom8 now uses the new style initialisers

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: link failure (drivers/char/riscom8.c) (240test13p2)

[Rasmus Andersen]

On Sat, Dec 16, 2000 at 10:37:59PM +0000, Alan Cox wrote:
> Remove the call from tty_init. riscom8 now uses the new style initialisers

I guess this would do it then.


--- linux-240-t13-pre2-clean/drivers/char/tty_io.c	Thu Dec 14 20:13:29 2000
+++ linux/drivers/char/tty_io.c	Sun Dec 17 09:27:32 2000
@@ -2319,9 +2319,6 @@
 #ifdef CONFIG_DIGIEPCA
 	pc_init();
 #endif
-#ifdef CONFIG_RISCOM8
-	riscom8_init();
-#endif
 #ifdef CONFIG_SPECIALIX
 	specialix_init();
 #endif


-- 
Regards,
        Rasmus(rasmus@jaquet.dk)

Cutler Webster's Law: There are two sides to every argument, unless a 
person is personally involved, in which case there is only one. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/