public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.2 - wanxl unchecked copy_to_user
Date: Tue, 19 Dec 2000 20:10:02 -0200	[thread overview]
Message-ID: <20001219201001.L764@conectiva.com.br> (raw)

Hi,

	Please consider applying, there must well be other things to do on
this failure, please check.

                        - Arnaldo

--- linux-2.2.19-2/drivers/net/wanxl.c	Wed Jun  7 18:26:43 2000
+++ linux-2.2.19-2.acme/drivers/net/wanxl.c	Tue Dec 19 20:05:53 2000
@@ -1088,7 +1088,10 @@
 
 	writel(1, &card->config->valid);
   
-	copy_to_user(data, card->config, sizeof(board_cfg));
+	if (copy_to_user(data, card->config, sizeof(board_cfg))) {
+		wanxl_destroy_card(card, 0);
+		return -EFAULT;
+	}
 	*length=sizeof(board_cfg);
 	card->running=1;
 	return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

                 reply	other threads:[~2000-12-20  0:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20001219201001.L764@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox