From: Rasmus Andersen <rasmus@jaquet.dk>
To: Torben Mathiasen <torben@kernel.dk>
Cc: Francois Romieu <romieu@cogenit.fr>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] Converting drivers/net/rcpci45.c to new PCI API
Date: Tue, 19 Dec 2000 22:49:04 +0100 [thread overview]
Message-ID: <20001219224904.D639@jaquet.dk> (raw)
In-Reply-To: <20001219004604.B761@jaquet.dk> <20001219095906.A5764@se1.cogenit.fr> <20001219220530.A1643@torben>
In-Reply-To: <20001219220530.A1643@torben>; from torben@kernel.dk on Tue, Dec 19, 2000 at 10:05:30PM +0100
On Tue, Dec 19, 2000 at 10:05:30PM +0100, Torben Mathiasen wrote:
>
> You should release the irq when the adapter is closed, not removed,
> unless there's some special case that can't be handled if you take
> ints during init.
You seem to be right. I have moved the free_irq to the close function.
>
> And why would you unregister your netdev after releasing resources?
>
Instead of doing it before? Beats me :) I merely/blindly copied the
existing sequence, but after RTFS'ing I changed the sequence to:
unregister_netdev(dev);
iounmap((void *)dev->base_addr);
kfree(dev);
Thank you for your comments.
--
Regards,
Rasmus(rasmus@jaquet.dk)
Freedom of the press is limited to those who own one.
- A.J. Liebling
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-19 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-18 23:46 [PATCH][RFC] Converting drivers/net/rcpci45.c to new PCI API Rasmus Andersen
2000-12-19 8:59 ` Francois Romieu
2000-12-19 9:10 ` Rasmus Andersen
2000-12-19 21:05 ` Torben Mathiasen
2000-12-19 21:49 ` Rasmus Andersen [this message]
2000-12-19 22:23 ` Torben Mathiasen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001219224904.D639@jaquet.dk \
--to=rasmus@jaquet.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@cogenit.fr \
--cc=torben@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox