From: Torben Mathiasen <torben@kernel.dk>
To: Rasmus Andersen <rasmus@jaquet.dk>
Cc: Francois Romieu <romieu@cogenit.fr>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] Converting drivers/net/rcpci45.c to new PCI API
Date: Tue, 19 Dec 2000 23:23:46 +0100 [thread overview]
Message-ID: <20001219232346.A1705@torben> (raw)
In-Reply-To: <20001219004604.B761@jaquet.dk> <20001219095906.A5764@se1.cogenit.fr> <20001219220530.A1643@torben> <20001219224904.D639@jaquet.dk>
In-Reply-To: <20001219224904.D639@jaquet.dk>; from rasmus@jaquet.dk on Tue, Dec 19, 2000 at 10:49:04PM +0100
On Tue, Dec 19 2000, Rasmus Andersen wrote:
> On Tue, Dec 19, 2000 at 10:05:30PM +0100, Torben Mathiasen wrote:
> >
> > You should release the irq when the adapter is closed, not removed,
> > unless there's some special case that can't be handled if you take
> > ints during init.
>
> You seem to be right. I have moved the free_irq to the close function.
>
This driver seems a bit odd. It also request irq's durint init instead
of device open. Normally one would request any resource as late as
possible (to prevent the driver from using resources when it is
not even used). It makes one wonder if this driver has just not
been updated in a while, or if it does things for a reason.
--
Torben Mathiasen <torben@kernel.dk>
Linux ThunderLAN maintainer
http://tlan.kernel.dk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-12-19 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-18 23:46 [PATCH][RFC] Converting drivers/net/rcpci45.c to new PCI API Rasmus Andersen
2000-12-19 8:59 ` Francois Romieu
2000-12-19 9:10 ` Rasmus Andersen
2000-12-19 21:05 ` Torben Mathiasen
2000-12-19 21:49 ` Rasmus Andersen
2000-12-19 22:23 ` Torben Mathiasen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001219232346.A1705@torben \
--to=torben@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=rasmus@jaquet.dk \
--cc=romieu@cogenit.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox