public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Epler <jepler@inetnebr.com>
To: Steve Grubb <ddata@gate.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] performance enhancement for simple_strtoul
Date: Wed, 20 Dec 2000 10:04:47 -0600	[thread overview]
Message-ID: <20001220100446.A1249@inetnebr.com> (raw)
In-Reply-To: <000e01c06a8e$6945db60$bc1a24cf@master>
In-Reply-To: <000e01c06a8e$6945db60$bc1a24cf@master>; from ddata@gate.net on Wed, Dec 20, 2000 at 09:09:03AM -0500

On Wed, Dec 20, 2000 at 09:09:03AM -0500, Steve Grubb wrote:
> Hello,
> 
> The following patch is a faster implementation of the simple_strtoul
> function.
[snip]

Why not preserve the existing code for bases other than 8, 10, and 16?
Admittedly, the only other case that is likely to be used would be base
2, but surely there's only a penalty of a few dozen bytes for the
following code..
> - while (isxdigit(*cp) && (value = isdigit(*cp) ? *cp-'0' : (islower(*cp)
> -     ? toupper(*cp) : *cp)-'A'+10) < base) {
> -  result = result*base + value;
> -  cp++;
> - }

Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2000-12-20 16:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-12-20 14:09 [Patch] performance enhancement for simple_strtoul Steve Grubb
2000-12-20 16:04 ` Jeff Epler [this message]
2000-12-20 16:35   ` Steve Grubb
2000-12-20 18:42   ` Steve Grubb
2000-12-21  0:09     ` Jamie Lokier
2000-12-21 20:06       ` Pavel Machek
2000-12-28  5:15         ` Jamie Lokier
2000-12-21  9:16 ` Matthias Andree
2000-12-21 10:28   ` Bernd Schmidt
2000-12-21 16:07   ` Alan Cox
2000-12-21 20:05 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20001220100446.A1249@inetnebr.com \
    --to=jepler@inetnebr.com \
    --cc=ddata@gate.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox