From: Andries Brouwer <aeb@veritas.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Christoph Rohland <cr@sap.com>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, Dave Gilbert <gilbertd@treblig.org>
Subject: Re: [Patch] shmmin behaviour back to 2.2 behaviour
Date: Wed, 27 Dec 2000 21:57:03 +0100 [thread overview]
Message-ID: <20001227215703.A1302@veritas.com> (raw)
In-Reply-To: <m3d7eeb1pa.fsf@linux.local> <Pine.LNX.4.21.0012271316020.11471-100000@freak.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0012271316020.11471-100000@freak.distro.conectiva>; from marcelo@conectiva.com.br on Wed, Dec 27, 2000 at 01:16:44PM -0200
On Wed, Dec 27, 2000 at 01:16:44PM -0200, Marcelo Tosatti wrote:
>
> On 27 Dec 2000, Christoph Rohland wrote:
>
> > Hi Linus,
> >
> > The following patchlet bring the handling of shmget with size zero
> > back to the 2.2 behaviour. There seem to be programs out, which
> > (erroneously) rely on this.
>
> Just curiosity: do you know if any specification (POSIX?) defines this
> behaviour?
I happen to see this post, but have not followed earlier discussion.
See a patch fragment
-#define SHMMIN 0 /* min shared seg size (bytes) */
+#define SHMMIN 1 /* min shared seg size (bytes) */
+ if (size < SHMMIN || size > shm_ctlmax)
+ return -EINVAL;
My first reaction is that this patch is broken, since
one usually specifies size 0 in shmget to get an existing
bit of shared memory (with known key but unknown size).
[Was this rehashed in earlier discussion? I wonder whether there
are any reasons to forbid size 0. Forbidding size 0 is
allowed by SUSv2 as I read it - it says
The shmget() function will fail if:
[EINVAL]
The value of size is less than the system-imposed minimum
or greater than the system-imposed maximum,
or a shared memory identifier exists for the argument key
but the size of the segment associated with it is less
than size and size is not 0.
but is contrary to AIX, which says
EINVAL
A shared memory identifier does not exist and the Size
parameter is less than the system-imposed minimum or greater
than the system-imposed maximum.
EINVAL
A shared memory identifier exists for the Key parameter,
but the size of the segment associated with it is less than
the Size parameter, and the Size parameter is not equal to 0.
and is also contrary to the SysVR4 implementation.]
Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-27 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-27 10:32 [Patch] shmmin behaviour back to 2.2 behaviour Christoph Rohland
2000-12-27 11:58 ` Dave Gilbert
2000-12-27 15:37 ` Christoph Rohland
2000-12-27 15:16 ` Marcelo Tosatti
2000-12-27 17:54 ` Christoph Rohland
2000-12-27 20:57 ` Andries Brouwer [this message]
2000-12-28 12:01 ` Christoph Rohland
2000-12-28 13:34 ` Andries Brouwer
2000-12-28 15:49 ` Alan Cox
2000-12-28 22:13 ` Christoph Rohland
2000-12-28 22:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001227215703.A1302@veritas.com \
--to=aeb@veritas.com \
--cc=cr@sap.com \
--cc=gilbertd@treblig.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox