From: Jens Axboe <axboe@suse.de>
To: Andrea Arcangeli <andrea@suse.de>
Cc: schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: plug problem in linux-2.4.0-test11
Date: Thu, 28 Dec 2000 14:47:59 +0100 [thread overview]
Message-ID: <20001228144759.C386@suse.de> (raw)
In-Reply-To: <C12569A6.00425037.00@d12mta07.de.ibm.com> <20001227210426.B10446@athlon.random>
In-Reply-To: <20001227210426.B10446@athlon.random>; from andrea@suse.de on Wed, Dec 27, 2000 at 09:04:26PM +0100
On Wed, Dec 27 2000, Andrea Arcangeli wrote:
> I think right behaviour of the blkdev layer is to BUG() if the driver eats
> requests while the device is plugged.
The device is supposed to know what it's doing. Sure it defeats the
elevators work a bit, but again the driver should know best. Besides, it
doesn't seem worthwhile to go to any lengths detecting this.
But in general I agree, device request_fn should never touch a plugged
queue.
--
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-12-28 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-29 11:56 plug problem in linux-2.4.0-test11 schwidefsky
2000-11-29 14:23 ` Jens Axboe
2000-11-29 17:52 ` Linus Torvalds
2000-11-29 18:11 ` Jens Axboe
2000-12-27 20:04 ` Andrea Arcangeli
2000-12-28 13:47 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001228144759.C386@suse.de \
--to=axboe@suse.de \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox