From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1298738F624; Fri, 17 Apr 2026 11:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776425579; cv=none; b=LDFQ7+VGRxZq+n8beW4meaI1Cw4XuozP1bg27D+ZpFnK4gb3K1IZEItHgPrka57EzIUTdC+SGPYQRMSzbyGsuzsTe+846alKChiFzpfgswGzRV2oL4iju71SHINsH1Z+eTnts3PtW992B/Df23CHpGuLtP7iL+YG66sbAflkJvg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776425579; c=relaxed/simple; bh=k4+ET8/QOuT35qKN9W9GJ9qGBMHPwac7NjI1uu6Xvoc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UO67rZfrtcFS0LoHTY+e1nLFFT61OOmg2ec0YG3Vm+iqJY0lf6uwAvyFPheGPAtggSSPjk8TAO+JIZZHNzMfOiN84zekccCNy7GE4JTOFs5OmW0jKYUGQarwHt/4nPIgopGMn8VdQax7J2hAV59D89zT9/7ZQ5UcVkg5i/g0Beg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=ALAyFiqJ; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="ALAyFiqJ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=8QyLMvKF44I/UarTwSVYz03wCTTEkLP4ZLZ/bSttUck=; b=ALAyFiqJXMslOeqg+jJlEYthCo UVRDtIAW0JAjYkBK0IDOoG6FsPd84Xv4i1Ede9QYaKCkqHrvMjyCxPlUT/xuVb9WgUwWePUhg62w2 uAFTXjOSfnRG2MOjpXKlwHIhHkPAJew55oBzmjYx39aV/86aIp4KZ816pzVVa4U9tdL/3s1kWc8l8 7SM7z+MCW0jJyYUOqy+im8sAxJBq0+NDoUYi/DJIogEoJn2gKHhkgJujwM5kyWeEqFekfyTdMWfMI L31z0CTJe/InBk/UkCtZnueMejzmzj9KHjjzzqZUdvzKqNjJ0t1TFpAbujQWTMAP773E/1vGMGqk7 HqjjK+WA==; From: Heiko Stuebner To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cristian Ciocaltea Cc: kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/40] arm64: dts: rockchip: Add frl-enable-gpios to rk3576-luckfox-core3576 Date: Fri, 17 Apr 2026 13:32:37 +0200 Message-ID: <2000470.6tgchFWduM@phil> In-Reply-To: <20260417-dts-rk-frl-enable-gpios-v1-5-a19c0dd8c9f6@collabora.com> References: <20260417-dts-rk-frl-enable-gpios-v1-0-a19c0dd8c9f6@collabora.com> <20260417-dts-rk-frl-enable-gpios-v1-5-a19c0dd8c9f6@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Cristian, the comments below apply sort of to all patches in that series. Am Freitag, 17. April 2026, 11:24:39 Mitteleurop=C3=A4ische Sommerzeit schr= ieb Cristian Ciocaltea: > The board exposes the GPIO4_C6 line to control the voltage bias on the > HDMI data lines. It must be asserted when operating in HDMI 2.1 FRL > mode and deasserted for HDMI 1.4/2.0 TMDS mode. >=20 > Wire up the HDMI node to the GPIO line using the frl-enable-gpios > property and drop the line from the vcc_5v0_hdmi regulator to allow > adjusting the bias when transitioning between TMDS and FRL operating > modes. >=20 > Signed-off-by: Cristian Ciocaltea > --- > arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi b/= arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi > index 749f0a54b478..93ae37699366 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi > @@ -140,10 +140,7 @@ regulator-state-mem { > =20 > vcc_5v0_hdmi: regulator-vcc-5v0-hdmi { > compatible =3D "regulator-fixed"; > - enable-active-high; > - gpios =3D <&gpio4 RK_PC6 GPIO_ACTIVE_HIGH>; > - pinctrl-names =3D "default"; > - pinctrl-0 =3D <&hdmi_con_en>; > + regulator-always-on; > regulator-min-microvolt =3D <5000000>; > regulator-max-microvolt =3D <5000000>; > regulator-name =3D "vcc_5v0_hdmi"; I think this regulator was sort of a complete hack, to set that gpio to some sort of default state, by declaring it as hdmi-pwr-supply. Only 2 rk3576 boards seem, to use that hack, so I think as that "regulator" is completely functionless now, the whole thing could be removed? > @@ -231,6 +228,8 @@ &gpu { > }; > =20 > &hdmi { > + pinctrl-0 =3D <&hdmi_txm0_pins &hdmi_tx_scl &hdmi_tx_sda &hdmi_frl_en>; > + frl-enable-gpios =3D <&gpio4 RK_PC6 GPIO_ACTIVE_LOW>; this should be sorted the other way around I think. Also please provide a pinctrl-names property too. If for whatever reason the dw-hdmi aquires a 2nd pinctrl state in the future, this makes sure board DTs are staying in the "old" compatible mode until they are adapted. > status =3D "okay"; > }; > =20 > @@ -655,7 +654,7 @@ &pcie0 { > =20 > &pinctrl { > hdmi { > - hdmi_con_en: hdmi-con-en { > + hdmi_frl_en: hdmi-frl-en { pinctrl names should ideally match the naming in schematics, for example the "HDMI0_TX_ON_H" for jaguar and tiger. This makes it way easier to go from DT to schematics and back. > rockchip,pins =3D <4 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>; > }; > }; >=20 >=20 Heiko