kNFSd maintenance in 2.2.19pre

kNFSd maintenance in 2.2.19pre

[Neil Brown]

Greeting all.

 Now that 2.2.18 is out with all the nfs (client and server) patches
 that we were waiting for for so long, it is time to look at on-going
 maintenance for knfsd.

 There are already a couple of issues that have come up and it is
 quite possible that more will arise as the user-base grows.
 Also, there are quite a few changes that have gone into 2.4 that
 could usefully go into 2.2.

 I have discussed the issue of maintenance with Dave Higgen - the
 maintainer of the knfsd patchset that finally went into 2.2.18, and
 he is happy to leave knfsd for a while and let me run with it.

 So, I have started putting some patches together and they can be
 found at
    http://www.cse.unsw.edu.au/~neilb/patches/knfsd-2.2/

 They are mostly back ports of bits from 2.4 with a couple of real bug
 fixes, one thanks to Chip Salzenberg and one which allows Solaris
 clients to access /dev/null over NFSv3 properly.

 I hope to feed these patches to Alan for inclusion in 2.2.19-preX
 early in the new year after I (and you?) have done a bit of testing.

 Note: the patches aren't all quite as independant as they should be
 just at the moment (e.g. I made a patch, started on another and then
 found a bug in the first, so the fix for the first ended up in the
 second).  This will get sorted out next time I generate a patch set.

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [NFS] kNFSd maintenance in 2.2.19pre

[Jay Weber]

Hi Neil,

This sounds good.  Any plans on implementing a backport of the nfs
filesystem layer for handling inodes that you put together for
2.4.  Ie.. the code that reiserfs uses in 2.4 to properly work with knfsd
and inode issues.


On Thu, 21 Dec 2000, Neil Brown wrote:

> 
> Greeting all.
> 
>  Now that 2.2.18 is out with all the nfs (client and server) patches
>  that we were waiting for for so long, it is time to look at on-going
>  maintenance for knfsd.
> 
>  There are already a couple of issues that have come up and it is
>  quite possible that more will arise as the user-base grows.
>  Also, there are quite a few changes that have gone into 2.4 that
>  could usefully go into 2.2.
> 
>  I have discussed the issue of maintenance with Dave Higgen - the
>  maintainer of the knfsd patchset that finally went into 2.2.18, and
>  he is happy to leave knfsd for a while and let me run with it.
> 
>  So, I have started putting some patches together and they can be
>  found at
>     http://www.cse.unsw.edu.au/~neilb/patches/knfsd-2.2/
> 
>  They are mostly back ports of bits from 2.4 with a couple of real bug
>  fixes, one thanks to Chip Salzenberg and one which allows Solaris
>  clients to access /dev/null over NFSv3 properly.
> 
>  I hope to feed these patches to Alan for inclusion in 2.2.19-preX
>  early in the new year after I (and you?) have done a bit of testing.
> 
>  Note: the patches aren't all quite as independant as they should be
>  just at the moment (e.g. I made a patch, started on another and then
>  found a bug in the first, so the fix for the first ended up in the
>  second).  This will get sorted out next time I generate a patch set.
> 
> NeilBrown
> 
> _______________________________________________
> NFS maillist  -  NFS@lists.sourceforge.net
> http://lists.sourceforge.net/mailman/listinfo/nfs
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: kNFSd maintenance in 2.2.19pre

[Andrea Arcangeli]

On Thu, Dec 21, 2000 at 12:05:41PM +1100, Neil Brown wrote:
>  So, I have started putting some patches together and they can be
>  found at
>     http://www.cse.unsw.edu.au/~neilb/patches/knfsd-2.2/

I included the interesting ones in my tree.

Here two fixes against the vfs backport:

--- ./fs/nfsd/vfs.c.~1~	Fri Dec 29 18:02:01 2000
+++ ./fs/nfsd/vfs.c	Mon Jan  1 18:09:46 2001
@@ -1603,9 +1603,11 @@
 	eof = !cd.eob;
 
 	if (cd.offset) {
+#ifdef CONFIG_NFSD_V3
 		if (rqstp->rq_vers == 3)
 			(void)enc64(cd.offset, file.f_pos);
 		else
+#endif /* CONFIG_NFSD_V3 */
 			*cd.offset = htonl(file.f_pos);
 	}
 
@@ -1624,6 +1626,7 @@
 	return err;
 
 out_nfserr:
+	up(&inode->i_sem);
 	err = nfserrno(-err);
 	goto out_close;
 }

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: kNFSd maintenance in 2.2.19pre

[Neil Brown]

On Monday January 1, andrea@suse.de wrote:
> On Thu, Dec 21, 2000 at 12:05:41PM +1100, Neil Brown wrote:
> >  So, I have started putting some patches together and they can be
> >  found at
> >     http://www.cse.unsw.edu.au/~neilb/patches/knfsd-2.2/
> 
> I included the interesting ones in my tree.

But aren't they all interesting :-)

I've up-dated and re-organised them and added some more.  The new set
can be found at 
  http://www.cse.unsw.edu.au/~neilb/patches/knfsd-2.2/2.2.19-pre7

There is a list of the patches below. 
I plan to send (most of) the to Alan shortly.

> 
> Here two fixes against the vfs backport:
> 
> --- ./fs/nfsd/vfs.c.~1~	Fri Dec 29 18:02:01 2000
> +++ ./fs/nfsd/vfs.c	Mon Jan  1 18:09:46 2001
> @@ -1603,9 +1603,11 @@
>  	eof = !cd.eob;
>  
>  	if (cd.offset) {
> +#ifdef CONFIG_NFSD_V3
>  		if (rqstp->rq_vers == 3)
>  			(void)enc64(cd.offset, file.f_pos);
>  		else
> +#endif /* CONFIG_NFSD_V3 */
>  			*cd.offset = htonl(file.f_pos);
>  	}

I deliberately removed the #ifdef here because I don't like ifdefs (I
have learned from the master) and this one wan't really needed.
Ofcourse, it may not compile like this unless you change "enc64" to
"xdr_encode_hyper" as a later patch did.

>  
> @@ -1624,6 +1626,7 @@
>  	return err;
>  
>  out_nfserr:
> +	up(&inode->i_sem);
>  	err = nfserrno(-err);
>  	goto out_close;
>  }

Oops. Thanks for catching this.

NeilBrown

  From my web page: http://www.cse.unsw.edu.au/~neilb/patches/knfsd-2.2

2.2.19-pre7
          Last Changed: 10 January 2001, 2:52pm GMT--11 Click me for more detailed patch descriptions

     

     patch-A-maint
                    Update the MAINTAINERS file
     patch-B-sema
                    Broaden the range of effect of the s_nfsd_free_path_sem semphore
     patch-C-access
                    Allow ACCESS checks on special files - plus bug fix
     patch-D-nfsirix
                    Make nfsd treat devices/pipes in a way that works with IRIX
     patch-E-wdelay
                    Modify the wdelay handling
     patch-F-stablewrite
                    Tidyup communication of stable-write flag - backport from 2.4
     patch-G-errtidy
                    Tidy up handling of error codes - back port from 2.4
     patch-H-dotent
                    move define oif dotent and change memcpyto xdr_encode_string
     patch-I-backport
                    Further back port of bits and pieces from 2.4
     patch-J-return
                    backport changes to RETURN macros in nfs*proc.c
     patch-K-enc64
                    replace enc64/dec64 by xdr_encode_hyper/xdr_decode_hyper
     patch-L-noigetinuse
                    Remove iget_in_use
     patch-M-hash
                    Calculate hash correctly for new names
     patch-N-arrangedentry
                    Tidy up the choosing of a dentry given an inode.
     patch-O-backportvfs
                    backport some 2.4 changes to vfs.c
     patch-P-create
                    modify exclusive create to not return negative times
     patch-Q-dotdot
                    move guard against creating dot or dotdot earlier
     patch-R-noexperiment
                    Remove 'experimental' tag from nfsv3 server support
     patch-S-setport
                    allow explicit setting of port number for lockd
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/