public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bill Nottingham <notting@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: alan@redhat.com
Subject: Re: prerelease-ac6 compile problem in serial.c
Date: Thu, 4 Jan 2001 17:42:12 -0500	[thread overview]
Message-ID: <20010104174212.A27418@devserv.devel.redhat.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0101050022210.9014-100000@madli.ut.ee>
In-Reply-To: <Pine.GSO.4.21.0101050022210.9014-100000@madli.ut.ee>; from mroos@linux.ee on Fri, Jan 05, 2001 at 12:23:48AM +0200

Meelis Roos (mroos@linux.ee) said: 
> 2.4.0-prerelease-ac6 doesn't compile serial on x86 with pnp enabled:
> 
> serial.c: In function `probe_serial_pnp':
> serial.c:5187: structure has no member named `device'
> serial.c:5192: structure has no member named `device'

Doh. I swear this did build when I tried it, although I don't see how.

Bill

--- linux/drivers/char/serial.c.foo	Thu Jan  4 17:31:43 2001
+++ linux/drivers/char/serial.c	Thu Jan  4 17:32:38 2001
@@ -5184,12 +5184,12 @@
 	       
 	       for (pnp_board = pnp_devices; pnp_board->vendor; pnp_board++)
 		       if ((dev->vendor == pnp_board->vendor) &&
-			   (dev->device == pnp_board->device))
+			   (dev->device == pnp_board->function))
 			       break;
 
 	       if (pnp_board->vendor) {
 		       board.vendor = pnp_board->vendor;
-		       board.device = pnp_board->device;
+		       board.device = pnp_board->function;
 		       /* Special case that's more efficient to hardcode */
 		       if ((board.vendor == ISAPNP_VENDOR('A', 'K', 'Y') &&
 			    board.device == ISAPNP_DEVICE(0x1021)))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      reply	other threads:[~2001-01-04 22:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-04 22:23 prerelease-ac6 compile problem in serial.c Meelis Roos
2001-01-04 22:42 ` Bill Nottingham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010104174212.A27418@devserv.devel.redhat.com \
    --to=notting@redhat.com \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox