reset_xmit_timer errors with 2.4.0

reset_xmit_timer errors with 2.4.0

[Patrick Michael Kane]

Hello!

I've installed 2.4.0 on a system that has been tracking 2.3.xx/2.4test for
quite a while.  With 2.4.0 installed, I've started to see the following
errors:

reset_xmit_timer sk=cfd889a0 1 when=0x3b4a, caller=c01e0748
reset_xmit_timer sk=cfd889a0 1 when=0x3a80, caller=c01e0748
reset_xmit_timer sk=cfd889a0 1 when=0x398a, caller=c01e0748
reset_xmit_timer sk=cfd889a0 1 when=0x389e, caller=c01e0748
reset_xmit_timer sk=cfd889a0 1 when=0x37b6, caller=c01e0748

It's a UP system with no kernel patches, running an eepro100 card.  I did
not get these errors under any of the 2.4test kernels.  Should I be worried?

Best,
-- 
Patrick Michael Kane
<modus@pr.es.to>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: reset_xmit_timer errors with 2.4.0

[Arkadiusz Miskiewicz]

On/Dnia Fri, Jan 05, 2001 at 06:52:52AM -0800, Patrick Michael Kane wrote/napisał(a)
> With 2.4.0 installed, I've started to see the following errors:
> 
> reset_xmit_timer sk=cfd889a0 1 when=0x3b4a, caller=c01e0748
> reset_xmit_timer sk=cfd889a0 1 when=0x3a80, caller=c01e0748
>
the same problem here + a lot of:
inet6_ifa_finish_destroy
inet6_ifa_finish_destroy
inet6_ifa_finish_destroy
messages from kernel.

> It's a UP system with no kernel patches, running an eepro100 card.
RTL-8029(AS) here but I guess that bug is somwhere else not at eth layer/level.

> Patrick Michael Kane

-- 
Arkadiusz Miśkiewicz, AM2-6BONE    [ PLD GNU/Linux IPv6 ]
http://www.t17.ds.pwr.wroc.pl/~misiek/ipv6/   [ enabled ]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: reset_xmit_timer errors with 2.4.0

[David S. Miller]

   Date: 	Fri, 5 Jan 2001 19:22:39 +0100
   From: Arkadiusz Miskiewicz <misiek@pld.ORG.PL>

   On/Dnia Fri, Jan 05, 2001 at 06:52:52AM -0800, Patrick Michael Kane wrote
   > With 2.4.0 installed, I've started to see the following errors:
   > 
   > reset_xmit_timer sk=cfd889a0 1 when=0x3b4a, caller=c01e0748
   > reset_xmit_timer sk=cfd889a0 1 when=0x3a80, caller=c01e0748
   >

   the same problem here

Does the following patch fix this for people?

--- net/ipv4/tcp_input.c.~1~	Wed Dec 13 10:31:48 2000
+++ net/ipv4/tcp_input.c	Fri Jan  5 17:01:53 2001
@@ -1705,7 +1705,7 @@
 
 		if ((__s32)when < (__s32)tp->rttvar)
 			when = tp->rttvar;
-		tcp_reset_xmit_timer(sk, TCP_TIME_RETRANS, when);
+		tcp_reset_xmit_timer(sk, TCP_TIME_RETRANS, min(when, TCP_RTO_MAX));
 	}
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: reset_xmit_timer errors with 2.4.0

[Patrick Michael Kane]

* David S. Miller (davem@redhat.com) [010105 17:08]:
>    Date: 	Fri, 5 Jan 2001 19:22:39 +0100
>    From: Arkadiusz Miskiewicz <misiek@pld.ORG.PL>
> 
>    On/Dnia Fri, Jan 05, 2001 at 06:52:52AM -0800, Patrick Michael Kane wrote
>    > With 2.4.0 installed, I've started to see the following errors:
>    > 
>    > reset_xmit_timer sk=cfd889a0 1 when=0x3b4a, caller=c01e0748
>    > reset_xmit_timer sk=cfd889a0 1 when=0x3a80, caller=c01e0748
>    >
> 
>    the same problem here
> 
> Does the following patch fix this for people?
[snip]

This seems to fix it here, thanks.

Best,
-- 
Patrick Michael Kane
<modus@pr.es.to>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/