public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bagetlance using freed skb
@ 2001-01-06 23:35 Arnaldo Carvalho de Melo
  2001-01-07  0:39 ` [PATCH] atarilance " Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2001-01-06 23:35 UTC (permalink / raw)
  To: Alan Cox; +Cc: linux-kernel

Alan,

	Paul Gortmaker found a similar one for lance, so I'm looking at
some other drivers to see if this happens, bagetlance has it as well,
here is the patch.

	- Arnaldo

--- linux-2.4.0-ac2/drivers/net/bagetlance.c	Tue Dec 19 11:25:40 2000
+++ linux-2.4.0-ac2.acme/drivers/net/bagetlance.c	Sat Jan  6 21:27:50 2001
@@ -930,9 +930,9 @@
 #else
     SET_FLAG(head,(TMD1_OWN_CHIP | TMD1_ENP | TMD1_STP));
 #endif
+	lp->stats.tx_bytes += skb->len;
 	dev_kfree_skb( skb );
 	lp->cur_tx++;
-	lp->stats.tx_bytes += skb->len;
 	while( lp->cur_tx >= TX_RING_SIZE && lp->dirty_tx >= TX_RING_SIZE ) {
 		lp->cur_tx -= TX_RING_SIZE;
 		lp->dirty_tx -= TX_RING_SIZE;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] atarilance using freed skb
  2001-01-06 23:35 [PATCH] bagetlance using freed skb Arnaldo Carvalho de Melo
@ 2001-01-07  0:39 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2001-01-07  0:39 UTC (permalink / raw)
  To: Alan Cox; +Cc: linux-kernel

Em Sat, Jan 06, 2001 at 09:35:08PM -0200, Arnaldo Carvalho de Melo escreveu:
> Alan,
> 
> 	Paul Gortmaker found a similar one for lance, so I'm looking at
> some other drivers to see if this happens, bagetlance has it as well,
> here is the patch.

Another one:

--- linux-2.4.0-ac2/drivers/net/atarilance.c	Mon Jan  1 14:42:28 2001
+++ linux-2.4.0-ac2.acme/drivers/net/atarilance.c	Sat Jan  6 22:36:23 2001
@@ -820,9 +820,9 @@
 	head->misc = 0;
 	lp->memcpy_f( PKTBUF_ADDR(head), (void *)skb->data, skb->len );
 	head->flag = TMD1_OWN_CHIP | TMD1_ENP | TMD1_STP;
+	lp->stats.tx_bytes += skb->len;
 	dev_kfree_skb( skb );
 	lp->cur_tx++;
-	lp->stats.tx_bytes += skb->len;
 	while( lp->cur_tx >= TX_RING_SIZE && lp->dirty_tx >= TX_RING_SIZE ) {
 		lp->cur_tx -= TX_RING_SIZE;
 		lp->dirty_tx -= TX_RING_SIZE;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-01-07  0:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-01-06 23:35 [PATCH] bagetlance using freed skb Arnaldo Carvalho de Melo
2001-01-07  0:39 ` [PATCH] atarilance " Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox