From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Steve.Ralston@lsil.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mptctl.c memory leak on failure
Date: Sun, 7 Jan 2001 14:09:17 -0200 [thread overview]
Message-ID: <20010107140917.A8810@conectiva.com.br> (raw)
In-Reply-To: <20010107011226.C8362@conectiva.com.br> <E14FG0b-0002dZ-00@the-village.bc.nu>
In-Reply-To: <E14FG0b-0002dZ-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Sun, Jan 07, 2001 at 01:37:15PM +0000
Em Sun, Jan 07, 2001 at 01:37:15PM +0000, Alan Cox escreveu:
> > kmalloc and the comment: the buffer is used for DMA but the kmalloc doesn't
> > has GFP_DMA, maybe I'm missing something here, its about time for me to
>
> It should be kmalloc (or 2.4 wise pci_alloc_* I guess eventually). Its driven
> by 32bit busmaster DMA. Its non ISA so it doesnt need GFP_DMA
yap, I should have have some sleep before suggesting that 8) Now back
looking at the other files, I've found another not so grave potential
memory leak, patch in some minutes
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2001-01-07 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-07 3:12 [PATCH] mptctl.c memory leak on failure Arnaldo Carvalho de Melo
2001-01-07 13:37 ` Alan Cox
2001-01-07 16:09 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010107140917.A8810@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=Steve.Ralston@lsil.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox