* [PATCH] n_r3964: restore_flags on failure
@ 2001-01-09 16:33 Arnaldo Carvalho de Melo
2001-01-10 1:41 ` David Woodhouse
0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2001-01-09 16:33 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel
Hi,
Please consider applying.
- Arnaldo
--- linux-2.4.0-ac4/drivers/char/n_r3964.c Tue Dec 19 11:25:34 2000
+++ linux-2.4.0-ac4.acme/drivers/char/n_r3964.c Tue Jan 9 14:23:07 2001
@@ -988,8 +988,10 @@
pMsg = kmalloc(sizeof(struct r3964_message), GFP_KERNEL);
TRACE_M("add_msg - kmalloc %x",(int)pMsg);
- if(pMsg==NULL)
+ if(pMsg==NULL) {
+ restore_flags(flags);
return;
+ }
pMsg->msg_id = msg_id;
pMsg->arg = arg;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] n_r3964: restore_flags on failure
2001-01-09 16:33 [PATCH] n_r3964: restore_flags on failure Arnaldo Carvalho de Melo
@ 2001-01-10 1:41 ` David Woodhouse
0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2001-01-10 1:41 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: Alan Cox, linux-kernel
On Tue, 9 Jan 2001, Arnaldo Carvalho de Melo wrote:
> --- linux-2.4.0-ac4/drivers/char/n_r3964.c Tue Dec 19 11:25:34 2000
> +++ linux-2.4.0-ac4.acme/drivers/char/n_r3964.c Tue Jan 9 14:23:07 2001
> + restore_flags(flags);
/me scratches head...
Err.... is there any reason to believe that the locking therein actually
works at all?
--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-01-10 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-01-09 16:33 [PATCH] n_r3964: restore_flags on failure Arnaldo Carvalho de Melo
2001-01-10 1:41 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox