From: Ralf Baechle <ralf@conectiva.com.br>
To: Pauline Middelink <middelin@polyware.nl>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
linux@advansys.com, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] advansys.c: include missing restore_flags, etc
Date: Wed, 10 Jan 2001 05:48:11 -0200 [thread overview]
Message-ID: <20010110054811.A19220@bacchus.dhis.org> (raw)
In-Reply-To: <20010108201103.E17087@conectiva.com.br> <20010108202533.F17087@conectiva.com.br> <20010108203002.H17087@conectiva.com.br> <20010109001443.A20786@conectiva.com.br> <20010109083007.A24914@polyware.nl>
In-Reply-To: <20010109083007.A24914@polyware.nl>; from middelink@polyware.nl on Tue, Jan 09, 2001 at 08:30:07AM +0100
On Tue, Jan 09, 2001 at 08:30:07AM +0100, Pauline Middelink wrote:
> > -STATIC int
> > +STATIC unsigned long
> > DvcEnterCritical(void)
> > {
> > - int flags;
> > + unsigned long flags;
> >
> > save_flags(flags);
> > cli();
> > @@ -9965,7 +9972,7 @@
> > }
>
> Err, according tho wise ppl on this list, this does not work on
> MIPSes. The flags thing must stay in the same stackframe.
Nope, that's on Sparc.
> > STATIC void
> > -DvcLeaveCritical(int flags)
> > +DvcLeaveCritical(unsigned long flags)
> > {
> > restore_flags(flags);
> > }
>
> Item.
My Latin teach says it's ``idem''.
Ralf
--
"Embrace, Enhance, Eliminate" - it worked for the pope, it'll work for Bill.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-10 8:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-08 22:11 [PATCH] de620.c: nitpicking Arnaldo Carvalho de Melo
2001-01-08 22:25 ` Arnaldo Carvalho de Melo
2001-01-08 22:30 ` [PATCH] tidy 53c7,8xx.c was " Arnaldo Carvalho de Melo
2001-01-09 2:14 ` [PATCH] advansys.c: include missing restore_flags, etc Arnaldo Carvalho de Melo
2001-01-09 7:30 ` Pauline Middelink
2001-01-09 10:06 ` Arnaldo Carvalho de Melo
2001-01-09 10:23 ` Alan Cox
2001-01-09 23:12 ` Pauline Middelink
2001-01-10 7:48 ` Ralf Baechle [this message]
2001-01-09 10:02 ` Russell King
2001-01-09 11:18 ` [PATCH] ad1848.c: include missing restore_flags Arnaldo Carvalho de Melo
2001-01-09 12:00 ` [PATCH] sscape.c: " Arnaldo Carvalho de Melo
2001-01-09 12:24 ` [PATCH] via-macii.c: restore_flags on failure Arnaldo Carvalho de Melo
2001-01-09 13:38 ` [PATCH] dn_keyb.c: " Arnaldo Carvalho de Melo
2001-01-09 16:17 ` Alan Cox
2001-01-09 15:30 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010110054811.A19220@bacchus.dhis.org \
--to=ralf@conectiva.com.br \
--cc=acme@conectiva.com.br \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@advansys.com \
--cc=middelin@polyware.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox