From: Andrea Arcangeli <andrea@suse.de>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Russell King <rmk@arm.linux.org.uk>,
Manfred Spraul <manfred@colorfullife.com>,
Hubert Mantel <mantel@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Compatibility issue with 2.2.19pre7
Date: Thu, 11 Jan 2001 19:43:54 +0100 [thread overview]
Message-ID: <20010111194354.F3560@athlon.random> (raw)
In-Reply-To: <20010110013755.D13955@suse.de> <200101100654.f0A6sjJ02453@flint.arm.linux.org.uk> <20010110163158.F19503@athlon.random> <shszogy2jmr.fsf@charged.uio.no> <3A5DDD09.C8C70D36@colorfullife.com> <14941.61668.697523.866481@charged.uio.no> <shsae8y2blg.fsf@charged.uio.no> <20010111192758.E3560@athlon.random> <14941.64473.902580.756312@charged.uio.no>
In-Reply-To: <14941.64473.902580.756312@charged.uio.no>; from trond.myklebust@fys.uio.no on Thu, Jan 11, 2001 at 07:30:49PM +0100
On Thu, Jan 11, 2001 at 07:30:49PM +0100, Trond Myklebust wrote:
> OK. In that case my patch, would just be amended to eliminate the
> redundant comparison as is the case below.
This patch looks fine w.r.t. alignment but given the below seems called
at runtime (not just at mount time) for performance and to save a dozen of bytes
of kernel stack it would probably better to use the nfs_fh structure in
2.2.19pre7 for the in-kernel representation and to define a new structure for
userspace message passing (defined as the nfs_fh in 2.2.19pre6). But at least
now we see _why_ it broke ;)
Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-11 18:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-10 0:37 Compatibility issue with 2.2.19pre7 Hubert Mantel
2001-01-10 0:43 ` Alan Cox
2001-01-10 6:54 ` Russell King
2001-01-10 15:31 ` Andrea Arcangeli
2001-01-10 22:09 ` Russell King
2001-01-10 23:59 ` Andrea Arcangeli
2001-01-11 7:34 ` Russell King
2001-01-11 10:33 ` Andi Kleen
2001-01-11 10:36 ` Russell King
2001-01-11 12:10 ` Manfred
2001-01-11 12:10 ` Andi Kleen
2001-01-11 12:29 ` Manfred
2001-01-11 13:27 ` Russell King
2001-01-24 7:51 ` Richard Henderson
2001-01-24 9:02 ` Andrea Arcangeli
2001-01-24 9:51 ` Richard Henderson
2001-01-24 12:21 ` Andrea Arcangeli
2001-01-24 17:49 ` Richard Henderson
2001-01-24 10:09 ` Thomas Pornin
2001-01-11 15:28 ` Trond Myklebust
2001-01-11 16:19 ` Manfred Spraul
2001-01-11 17:44 ` Trond Myklebust
2001-01-11 18:22 ` Trond Myklebust
2001-01-11 18:27 ` Andrea Arcangeli
2001-01-11 18:30 ` Trond Myklebust
2001-01-11 18:43 ` Andrea Arcangeli [this message]
2001-01-11 20:09 ` Russell King
2001-01-11 20:39 ` Trond Myklebust
2001-01-11 11:37 ` Trond Myklebust
-- strict thread matches above, loose matches on Subject: below --
2001-01-24 13:46 Jesse Pollard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010111194354.F3560@athlon.random \
--to=andrea@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mantel@suse.de \
--cc=rmk@arm.linux.org.uk \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox