Re: 2.4.1-pre1 breaks XFree 4.0.2 and "w"

Linus Torvalds
2001-01-12T17:35:54Z

On Fri, 12 Jan 2001, Andrea Arcangeli wrote:

> On Fri, Jan 12, 2001 at 11:42:32AM -0500, Richard A Nelson wrote:
> >
> > Its fine either way on current x86 and many other platforms, but falls
> > on its face in the presence of asymetric MP.
>
> Point taken, feel free to have a can_I_use per-cpu instead of global but don't
> overwrite the cpu_has with it.

Andrea, the whole POINT of "cpu_has_xxx" is for the kernel to test for
features like this.

If you're not going to overwrite it when some feature is deemed disabled,
you're missing the whole _reason_ for having capabilities bitmaps in the
first place.

This is not negotiable. We used to have a damn mess in 2.2.x with all the
capabilities stuff, and 2.4.x finally cleans it up and gets it right
across different CPU's, exactly because we have a clean "this CPU can do
X" approach without any if's, but's and why's.

The fact that 2.2.x has bad control over capabilities and is messy is NOT
an excuse to screw up forever.

Linus