public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@linuxcare.com.au>
To: Andreas Dilger <adilger@turbolinux.com>
Cc: Mauelshagen@sistina.com, linux-kernel@vger.kernel.org,
	linux-lvm@sistina.com, lvm@sistina.com
Subject: Re: *** ANNOUNCEMENT *** LVM 0.9.1 beta1 available at www.sistina.com
Date: Sat, 13 Jan 2001 14:00:58 +1100	[thread overview]
Message-ID: <20010113140058.E15915@linuxcare.com> (raw)
In-Reply-To: <20010113114507.D15915@linuxcare.com> <200101130143.f0D1hNF19829@webber.adilger.net>
In-Reply-To: <200101130143.f0D1hNF19829@webber.adilger.net>; from adilger@turbolinux.com on Fri, Jan 12, 2001 at 06:43:23PM -0700

 
Hi,

> What is the reason for all this?  Alignment/wordsize/other?  If you look
> at the IOP10 code, much of the in-core data structs were changed to int
> or long, so this sparc code may not be necessary.  It may in fact be
> damaging, because I don't know if any of the LVM developers even know it
> is there, and surely it will be out of sync...

Two things:

Structures used in ioctls should have explicit sizes (eg u32, not unsigned
long). Remember on sparc64 we have a 32 bit userspace and 64 bit kernel.

Having pointers to other structures is considered bad form again due to the
32bit/64bit differences. Think 32 bit pointers vs 64 bit pointers :)

When either of these happen we have to write up translation code. Of
the two, having pointers to other structs is definitely the worst. 

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2001-01-13  3:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-13  1:15 *** ANNOUNCEMENT *** LVM 0.9.1 beta1 available at www.sistina.com Heinz J. Mauelshagen
2001-01-13  0:45 ` Anton Blanchard
2001-01-13  1:43   ` Andreas Dilger
2001-01-13  3:00     ` Anton Blanchard [this message]
2001-01-13 16:06     ` [linux-lvm] " Christoph Hellwig
2001-01-14  1:23       ` Anton Blanchard
2001-01-16  8:51       ` Patrick Caulfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010113140058.E15915@linuxcare.com \
    --to=anton@linuxcare.com.au \
    --cc=Mauelshagen@sistina.com \
    --cc=adilger@turbolinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-lvm@sistina.com \
    --cc=lvm@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox