[PATCH] sparc64 compile fix

[PATCH] sparc64 compile fix

[Petru Paler]

--- arch/sparc64/kernel/sys_sparc32.c.orig      Sat Jan 13 07:59:43 2001
+++ arch/sparc64/kernel/sys_sparc32.c   Sat Jan 13 08:00:23 2001
@@ -904,7 +904,7 @@
 {
        int cmds = cmd >> SUBCMDSHIFT;
        int err;
-       struct dqblk d;
+       struct dqblk32 d;
        mm_segment_t old_fs;
        char *spec;                                                                       

--
Petru Paler, mailto:ppetru@ppetru.net
http://www.ppetru.net - ICQ: 41817235
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] sparc64 compile fix

[David S. Miller]

Petru Paler writes:
 > -       struct dqblk d;
 > +       struct dqblk32 d;

What does this fix?  Things compile just fine without
it and looking at the code it was intended to be of
the original type.

Please explain exactly what submitted patches fix in
the future, thanks.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] sparc64 compile fix

[Petru Paler]

On Sat, Jan 13, 2001 at 02:55:42PM -0800, David S. Miller wrote:
> Petru Paler writes:
>  > -       struct dqblk d;
>  > +       struct dqblk32 d;
> 
> What does this fix?  Things compile just fine without
> it and looking at the code it was intended to be of
> the original type.
> 
> Please explain exactly what submitted patches fix in
> the future, thanks.

Sorry, my fingers slipped and I sent the mail too fast :(

Trying to compile 2.4.0-ac8 resulted in an error about
storage size of variable d not being known (I don't have the
exact error at hand, the network connectivity to that server
is down right now). Changing it to dqblk32 got it to compile.

Am I doing something else wrong ?

--
Petru Paler, mailto:ppetru@ppetru.net
http://www.ppetru.net - ICQ: 41817235
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] sparc64 compile fix

[Alan Cox]

> What does this fix?  Things compile just fine without
> it and looking at the code it was intended to be of
> the original type.

2.4.0-ac has quota fixes (there are bad quota races in 2.4.0) and changes
to support 32bit uid. They aren't in the sparc64 diffs yet and until Linus
has the major bugs out they probably arent a major worry.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] sparc64 compile fix

[David S. Miller]

Petru Paler writes:
 > Trying to compile 2.4.0-ac8 resulted in an error about
 > storage size of variable d not being known (I don't have the
 > exact error at hand, the network connectivity to that server
 > is down right now). Changing it to dqblk32 got it to compile.
 > 
 > Am I doing something else wrong ?

If the quota interfaces have changed, then all of the translation code
support for them in sys_sparc32.c/systbls.S/etc. need to change to
accomodate.

Stick with non-AC kernels for no on sparc64, thanks. (But feel free to
use the zerocopy patches :-)

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] sparc64 compile fix

[Petru Paler]

On Sun, Jan 14, 2001 at 01:19:33AM -0800, David S. Miller wrote:
> Petru Paler writes:
>  > Trying to compile 2.4.0-ac8 resulted in an error about
>  > storage size of variable d not being known (I don't have the
>  > exact error at hand, the network connectivity to that server
>  > is down right now). Changing it to dqblk32 got it to compile.
>  > 
>  > Am I doing something else wrong ?
> 
> If the quota interfaces have changed, then all of the translation code
> support for them in sys_sparc32.c/systbls.S/etc. need to change to
> accomodate.
> 
> Stick with non-AC kernels for no on sparc64, thanks. (But feel free to
> use the zerocopy patches :-)

Ok :)

Actually I'm just looking for a kernel to run fast & smoothly on those servers...
Will give 2.4.0-pre3 + zerocopy a try.

--
Petru Paler, mailto:ppetru@ppetru.net
http://www.ppetru.net - ICQ: 41817235
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/