From: Jens Axboe <axboe@suse.de>
To: Andrea Arcangeli <andrea@suse.de>
Cc: andersg@0x63.nu, linux-kernel@vger.kernel.org
Subject: Re: lvm-oops in 2.4.1pre8
Date: Sat, 20 Jan 2001 19:50:27 +0100 [thread overview]
Message-ID: <20010120195027.Q30779@suse.de> (raw)
In-Reply-To: <20010120184106.A355@h55p111.delphi.afb.lu.se> <20010120192553.K8717@athlon.random>
In-Reply-To: <20010120192553.K8717@athlon.random>; from andrea@suse.de on Sat, Jan 20, 2001 at 07:25:53PM +0100
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
On Sat, Jan 20 2001, Andrea Arcangeli wrote:
> On Sat, Jan 20, 2001 at 06:41:06PM +0100, andersg@0x63.nu wrote:
> > hi,
> >
> > got this oops when doing a
> > vgextend -v vgroot /dev/ide/host2/bus0/target0/lun0/part2 \
> > /dev/ide/host2/bus1/target0/lun0/part2
>
> You should upgrade to 0.9.1_beta2 that should merge all the known fixes out
> there. It's planned for inclusion into 2.4.1.
If you are doing updates, could you include this patch too? All it does
is waste memory.
--
* Jens Axboe <axboe@suse.de>
* SuSE Labs
[-- Attachment #2: lvm-request_fn-1 --]
[-- Type: text/plain, Size: 1319 bytes --]
--- /kt/linux-2.4.1-pre9/drivers/md/lvm.c Fri Dec 29 23:07:22 2000
+++ drivers/md/lvm.c Sat Jan 20 19:50:59 2001
@@ -208,9 +208,6 @@
extern int lvm_init(void);
#endif
-static void lvm_dummy_device_request(request_queue_t *);
-#define DEVICE_REQUEST lvm_dummy_device_request
-
static int lvm_make_request_fn(request_queue_t*, int, struct buffer_head*);
static int lvm_blk_ioctl(struct inode *, struct file *, uint, ulong);
@@ -464,7 +461,6 @@
lvm_hd_name_ptr = lvm_hd_name;
#endif
- blk_init_queue(BLK_DEFAULT_QUEUE(MAJOR_NR), DEVICE_REQUEST);
blk_queue_make_request(BLK_DEFAULT_QUEUE(MAJOR_NR), lvm_make_request_fn);
/* optional read root VGDA */
@@ -504,7 +500,6 @@
if (unregister_blkdev(MAJOR_NR, lvm_name) < 0) {
printk(KERN_ERR "%s -- unregister_blkdev failed\n", lvm_name);
}
- blk_cleanup_queue(BLK_DEFAULT_QUEUE(MAJOR_NR));
gendisk_ptr = gendisk_ptr_prev = gendisk_head;
while (gendisk_ptr != NULL) {
@@ -1730,21 +1725,6 @@
return;
}
#endif
-
-
-/*
- * this one never should be called...
- */
-static void lvm_dummy_device_request(request_queue_t * t)
-{
- printk(KERN_EMERG
- "%s -- oops, got lvm request for %02d:%02d [sector: %lu]\n",
- lvm_name,
- MAJOR(CURRENT->rq_dev),
- MINOR(CURRENT->rq_dev),
- CURRENT->sector);
- return;
-}
/*
prev parent reply other threads:[~2001-01-20 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-20 17:41 lvm-oops in 2.4.1pre8 andersg
2001-01-20 18:25 ` Andrea Arcangeli
2001-01-20 18:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010120195027.Q30779@suse.de \
--to=axboe@suse.de \
--cc=andersg@0x63.nu \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox