From: Rasmus Andersen <rasmus@jaquet.dk>
To: lnz@dandelion.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH] drivers/scsi/BusLogic.c: No resource probing before pci_enable_device (241p11)
Date: Mon, 29 Jan 2001 22:48:38 +0100 [thread overview]
Message-ID: <20010129224838.I603@jaquet.dk> (raw)
Hi.
The following patch makes drivers/scsi/BusLogic.c wait with probing
pdev->irq and pdev->resource[] until we call pci_enable_device. This
is recommended due to hot-plug considerations (according to Jeff Garzik).
It applies against ac12 and 241p11.
Comments?
--- linux-ac12-clean/drivers/scsi/BusLogic.c Sat Jan 27 21:16:24 2001
+++ linux-ac12/drivers/scsi/BusLogic.c Sat Jan 27 21:32:33 2001
@@ -770,15 +770,19 @@
BusLogic_ModifyIOAddressRequest_T ModifyIOAddressRequest;
unsigned char Bus = PCI_Device->bus->number;
unsigned char Device = PCI_Device->devfn >> 3;
- unsigned int IRQ_Channel = PCI_Device->irq;
- unsigned long BaseAddress0 = pci_resource_start(PCI_Device, 0);
- unsigned long BaseAddress1 = pci_resource_start(PCI_Device, 1);
- BusLogic_IO_Address_T IO_Address = BaseAddress0;
- BusLogic_PCI_Address_T PCI_Address = BaseAddress1;
+ unsigned int IRQ_Channel;
+ unsigned long BaseAddress0;
+ unsigned long BaseAddress1;
+ BusLogic_IO_Address_T IO_Address;
+ BusLogic_PCI_Address_T PCI_Address;
if (pci_enable_device(PCI_Device))
continue;
+ IRQ_Channel = PCI_Device->irq;
+ IO_Address = BaseAddress0 = pci_resource_start(PCI_Device, 0);
+ PCI_Address = BaseAddress1 = pci_resource_start(PCI_Device, 1);
+
if (pci_resource_flags(PCI_Device, 0) & IORESOURCE_MEM)
{
BusLogic_Error("BusLogic: Base Address0 0x%X not I/O for "
--
Regards,
Rasmus(rasmus@jaquet.dk)
"The obvious mathematical breakthrough would be development of an easy way
to factor large prime numbers."
-- Bill Gates, The Road Ahead, Viking Penguin (1995)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2001-01-29 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-29 21:48 Rasmus Andersen [this message]
2001-01-30 4:51 ` [PATCH] drivers/scsi/BusLogic.c: No resource probing before pci_enable_device (241p11) Leonard N. Zubkoff
-- strict thread matches above, loose matches on Subject: below --
2001-01-30 14:58 rakesh rakesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010129224838.I603@jaquet.dk \
--to=rasmus@jaquet.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lnz@dandelion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox