[Patch] DVD bugfix in ide-cd.c

[Patch] DVD bugfix in ide-cd.c

[Fredrik Vraalsen]

This is a small patch to Linux kernel 2.4.1 that fixes a problem with
DVD playback in OMS (Open Media System).  With the stock 2.4.1 kernel
OMS will only play up to a certain point on the DVD before it complains
about no more data left on input (basically read() returns 0).  This
patch reverts a change between 2.4.0 and 2.4.1.


diff -u --recursive --new-file v2.4.0/linux/drivers/ide/ide-cd.c linux/drivers/ide/ide-cd.c
--- v2.4.0/linux/drivers/ide/ide-cd.c	Tue Jan  2 16:59:17 2001
+++ linux/drivers/ide/ide-cd.c	Sun Jan 28 13:37:50 2001
@@ -1872,6 +1872,9 @@
 	   If it is, just return. */
 	(void) cdrom_check_status(drive, sense);
 
+	if (CDROM_STATE_FLAGS(drive)->toc_valid)
+		return 0;
+
 	/* First read just the header, so we know how long the TOC is. */
 	stat = cdrom_read_tocentry(drive, 0, 1, 0, (char *) &toc->hdr,
 				    sizeof(struct atapi_toc_header), sense);


-- 
Fredrik Vraalsen  -  Research Assistant, Pablo research group
Department of Computer Science, University of Illinois at U-C
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [livid-dev] [Patch] DVD bugfix in ide-cd.c

[Szymon Polom]

Hi...

Fredrik Vraalsen wrote:
> 
> This is a small patch to Linux kernel 2.4.1 that fixes a problem with
> DVD playback in OMS (Open Media System).  With the stock 2.4.1 kernel
> OMS will only play up to a certain point on the DVD before it complains
> about no more data left on input (basically read() returns 0).  This
> patch reverts a change between 2.4.0 and 2.4.1.

What's wrong with the people maintaining the source? The bug has been
fixed in 2.2.18 and 2.4.0-test8. I can't imagine how the bug has been
"implemented" in 2.4.1 again.

Any ideas?

Bye... SP.
-- 
Szymon Polom                              polom@convergence.de
convergence integrated media GmbH         http://www.convergence.de
Rosenthaler Str. 51                       fon: +49(0)30-72 62 06 68 
D-10178 Berlin                            fax: +49(0)30-72 62 06 55
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [livid-dev] [Patch] DVD bugfix in ide-cd.c

[Szymon Polom]

Hello,

Szymon Polom wrote:

> Fredrik Vraalsen wrote:
> >
> > This is a small patch to Linux kernel 2.4.1 that fixes a problem with
> > DVD playback in OMS (Open Media System).  With the stock 2.4.1 kernel
> > OMS will only play up to a certain point on the DVD before it complains
> > about no more data left on input (basically read() returns 0).  This
> > patch reverts a change between 2.4.0 and 2.4.1.
> 
> What's wrong with the people maintaining the source? The bug has been
> fixed in 2.2.18 and 2.4.0-test8. I can't imagine how the bug has been
> "implemented" in 2.4.1 again.
> 
> Any ideas?

I have to revoke my statement. The cached toc problem i meant was in
cdrom_get_toc_entry() not in cdrom_read_toc().

Bye... SP.
-- 
Szymon Polom                              polom@convergence.de
convergence integrated media GmbH         http://www.convergence.de
Rosenthaler Str. 51                       fon: +49(0)30-72 62 06 68 
D-10178 Berlin                            fax: +49(0)30-72 62 06 55
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [Patch] DVD bugfix in ide-cd.c

[Jens Axboe]

On Thu, Feb 01 2001, Fredrik Vraalsen wrote:
> 
> This is a small patch to Linux kernel 2.4.1 that fixes a problem with
> DVD playback in OMS (Open Media System).  With the stock 2.4.1 kernel
> OMS will only play up to a certain point on the DVD before it complains
> about no more data left on input (basically read() returns 0).  This
> patch reverts a change between 2.4.0 and 2.4.1.

Thanks applied, guess we need another work-around for buggy changers...

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [Patch] DVD bugfix in ide-cd.c

[Andre Hedrick]

On Fri, 2 Feb 2001, Jens Axboe wrote:
> Thanks applied, guess we need another work-around for buggy changers...
> 
> -- 
> Jens Axboe

To quote my friend, about comments agreeing with Hale Landis.....
WHY!!! are you still supporting junk? ;-)

Cheers,

Andre Hedrick
Linux ATA Development
ASL Kernel Development
-----------------------------------------------------------------------------
ASL, Inc.                                     Toll free: 1-877-ASL-3535
1757 Houret Court                             Fax: 1-408-941-2071
Milpitas, CA 95035                            Web: www.aslab.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [Patch] DVD bugfix in ide-cd.c

[Peter Rasmussen]

This patch made it work for me watching DVDs that used to stop, ie. oms
crashed. So I'll approve the patch :-)

Peter

Fredrik Vraalsen <vraalsen@cs.uiuc.edu> on 01 Feb 2001 23:12:44 wrote:
>
>
>This is a small patch to Linux kernel 2.4.1 that fixes a problem with
>DVD playback in OMS (Open Media System).  With the stock 2.4.1 kernel
>OMS will only play up to a certain point on the DVD before it complains
>about no more data left on input (basically read() returns 0).  This
>patch reverts a change between 2.4.0 and 2.4.1.
>
>
>diff -u --recursive --new-file v2.4.0/linux/drivers/ide/ide-cd.c linux/drivers/ide/ide-cd.c
>--- v2.4.0/linux/drivers/ide/ide-cd.c	Tue Jan  2 16:59:17 2001
>+++ linux/drivers/ide/ide-cd.c	Sun Jan 28 13:37:50 2001
>@@ -1872,6 +1872,9 @@
> 	   If it is, just return. */
> 	(void) cdrom_check_status(drive, sense);
> 
>+	if (CDROM_STATE_FLAGS(drive)->toc_valid)
>+		return 0;
>+
> 	/* First read just the header, so we know how long the TOC is. */
> 	stat = cdrom_read_tocentry(drive, 0, 1, 0, (char *) &toc->hdr,
> 				    sizeof(struct atapi_toc_header), sense);
>
>
>-- 
>Fredrik Vraalsen  -  Research Assistant, Pablo research group
>Department of Computer Science, University of Illinois at U-C
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/